Review: getattribute for stats

Refactor ImageCache::getattribute and in the process make it so that we can retrieve all the statistics individually.  This is especially handy for two immediate uses: (1) makes it easier for apps to ask OIIO how much cache memory it has actually used, directly, without having to ask for full stats as a string and parse it; (2) makes it easier to write unit tests that expect a particular stat to have a certain value to confirm that something is working properly.

[Chris Foster, 2010-12-15 05:56:03]

LGTM

http://codereview.appspot.com/3597041/diff/1/src/libtexture/imagecache.cpp
File src/libtexture/imagecache.cpp (right):

http://codereview.appspot.com/3597041/diff/1/src/libtexture/imagecache.cpp#ne...
src/libtexture/imagecache.cpp:1647: if (! strncmp (name.c_str(), "stat:", 5)) {
How about the following

if(boost::starts_with(name, "stat:"))

included from boost/algorithm/string/predicate.hpp.  (There's also
std::string::compare(), but it's no clearer than the strncmp version.)

[lg_larrygritz.com, 2010-12-15 07:24:07]

Will do.


On Dec 14, 2010, at 9:56 PM, chris42f@gmail.com wrote:

> LGTM
> 
> 
> http://codereview.appspot.com/3597041/diff/1/src/libtexture/imagecache.cpp
> File src/libtexture/imagecache.cpp (right):
> 
>
http://codereview.appspot.com/3597041/diff/1/src/libtexture/imagecache.cpp#ne...
> src/libtexture/imagecache.cpp:1647: if (! strncmp (name.c_str(),
> "stat:", 5)) {
> How about the following
> 
> if(boost::starts_with(name, "stat:"))
> 
> included from boost/algorithm/string/predicate.hpp.  (There's also
> std::string::compare(), but it's no clearer than the strncmp version.)
> 
> http://codereview.appspot.com/3597041/
> _______________________________________________
> Oiio-dev mailing list
> Oiio-dev@lists.openimageio.org
> http://lists.openimageio.org/listinfo.cgi/oiio-dev-openimageio.org

--
Larry Gritz
lg@larrygritz.com