Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 35940049: code review 35940049: go.tools/go/types: print interface methods in sorted order (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by gri
Modified:
11 years, 10 months ago
Reviewers:
adonovan
CC:
adonovan, golang-dev
Visibility:
Public.

Description

go.tools/go/types: print interface methods in sorted order Required for testing code of clients.

Patch Set 1 #

Patch Set 2 : diff -r aca7c06737e1 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r aca7c06737e1 https://code.google.com/p/go.tools #

Total comments: 2

Patch Set 4 : diff -r aca7c06737e1 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 0014cfe5a7e9 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M go/types/objects.go View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M go/types/typestring.go View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6
gri
Hello adonovan@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
11 years, 10 months ago (2013-12-16 19:45:55 UTC) #1
adonovan
LGTM https://codereview.appspot.com/35940049/diff/40001/go/types/typestring.go File go/types/typestring.go (right): https://codereview.appspot.com/35940049/diff/40001/go/types/typestring.go#newcode89 go/types/typestring.go:89: // This us needed at the moment because ...
11 years, 10 months ago (2013-12-16 19:56:29 UTC) #2
gri
Hello adonovan@google.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 10 months ago (2013-12-16 21:33:43 UTC) #3
gri
https://codereview.appspot.com/35940049/diff/40001/go/types/typestring.go File go/types/typestring.go (right): https://codereview.appspot.com/35940049/diff/40001/go/types/typestring.go#newcode89 go/types/typestring.go:89: // This us needed at the moment because interfaces ...
11 years, 10 months ago (2013-12-16 21:34:24 UTC) #4
adonovan
On 2013/12/16 21:34:24, gri wrote: > https://codereview.appspot.com/35940049/diff/40001/go/types/typestring.go > File go/types/typestring.go (right): > > https://codereview.appspot.com/35940049/diff/40001/go/types/typestring.go#newcode89 > ...
11 years, 10 months ago (2013-12-16 21:50:48 UTC) #5
gri
11 years, 10 months ago (2013-12-16 21:53:03 UTC) #6
*** Submitted as
https://code.google.com/p/go/source/detail?r=f5af84eb78e1&repo=tools ***

go.tools/go/types: print interface methods in sorted order

Required for testing code of clients.

R=adonovan
CC=golang-dev
https://codereview.appspot.com/35940049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b