Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(309)

Issue 35940047: code review 35940047: cmd/gc: fix special-casing of the printed names of map ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by khr
Modified:
8 years, 1 month ago
Reviewers:
rsc
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: fix special-casing of the printed names of map internal structures. Shaves 1% off of binary size. update issue 6853

Patch Set 1 #

Patch Set 2 : diff -r 6c07f9492098 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 6c07f9492098 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 6c07f9492098 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 5b217021b2a8 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M src/cmd/gc/fmt.c View 1 1 chunk +11 lines, -7 lines 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/reflect.c View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
8 years, 1 month ago (2013-12-03 21:38:10 UTC) #1
rsc
LGTM
8 years, 1 month ago (2013-12-03 22:15:21 UTC) #2
khr
8 years, 1 month ago (2013-12-03 22:27:10 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=3afe9c5bc283 ***

cmd/gc: fix special-casing of the printed names of map internal structures.
Shaves 1% off of binary size.

update issue 6853

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/35940047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b