Issue 35850043: code review 35850043: freetype/truetype: track phantom points across compound...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35850043: code review 35850043: freetype/truetype: track phantom points across compound... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by nigeltao

Modified:
10 years, 7 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev, remyoudompheng

Visibility:
Public.

Description

freetype/truetype: track phantom points across compound glyphs. The very subtle pp1x versus phantomPoints[0].X distinction is pretty ugly code, but let's get all the tests passing first, so that we can refactor with confidence.

Patch Set 1 #

Patch Set 2 : diff -r 882e8392310a https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 882e8392310a https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r 882e8392310a https://code.google.com/p/freetype-go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -18 lines)			Patch
	M	freetype/truetype/glyph.go	View	1	9 chunks	+41 lines, -17 lines	0 comments	Download
	M	freetype/truetype/truetype_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remyoudompheng@gmail.com), I'd like you to review this change to https://code.google.com/p/freetype-go

10 years, 7 months ago (2013-12-02 04:37:53 UTC) #1

bsiegert

LGTM I admit that I have a hard time understanding these subtleties.

10 years, 7 months ago (2013-12-02 16:31:58 UTC) #2

nigeltao

10 years, 7 months ago (2013-12-02 21:22:02 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=9caf59b05a4d ***

freetype/truetype: track phantom points across compound glyphs.

The very subtle pp1x versus phantomPoints[0].X distinction is pretty
ugly code, but let's get all the tests passing first, so that we can
refactor with confidence.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/35850043

Expand All Messages | Collapse All Messages