Issue 35830043: code review 35830043: cmd/5a, cmd/6a, cmd/8a: use liblink

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35830043: code review 35830043: cmd/5a, cmd/6a, cmd/8a: use liblink (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
iant

CC:
iant, golang-dev

Visibility:
Public.

Description

cmd/5a, cmd/6a, cmd/8a: use liblink Preparation for golang.org/s/go13linker work. This CL does not build by itself. It depends on 35740044 and 35790044 and will be submitted at the same time.

Patch Set 2 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 00fa28348495 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1951 lines, -3626 lines)			Patch
M	src/cmd/5a/a.h	View	1 2 3 4	8 chunks	+5 lines, -39 lines	0 comments	Download
M	src/cmd/5a/a.y	View	1	11 chunks	+12 lines, -14 lines	0 comments	Download
M	src/cmd/5a/lex.c	View	1 2 3	9 chunks	+42 lines, -254 lines	0 comments	Download
M	src/cmd/5a/y.tab.h	View	1	3 chunks	+22 lines, -26 lines	0 comments	Download
M	src/cmd/5a/y.tab.c	View	1	60 chunks	+526 lines, -786 lines	0 comments	Download
M	src/cmd/6a/a.h	View	1	7 chunks	+10 lines, -41 lines	0 comments	Download
M	src/cmd/6a/a.y	View	1	5 chunks	+13 lines, -15 lines	0 comments	Download
M	src/cmd/6a/lex.c	View	1 2 3 4	6 chunks	+38 lines, -266 lines	0 comments	Download
M	src/cmd/6a/y.tab.h	View	1	3 chunks	+23 lines, -27 lines	0 comments	Download
M	src/cmd/6a/y.tab.c	View	1	54 chunks	+590 lines, -877 lines	0 comments	Download
M	src/cmd/8a/a.h	View	1	7 chunks	+9 lines, -43 lines	0 comments	Download
M	src/cmd/8a/a.y	View	1	5 chunks	+12 lines, -14 lines	0 comments	Download
M	src/cmd/8a/lex.c	View	1 2 3	6 chunks	+38 lines, -263 lines	0 comments	Download
M	src/cmd/8a/y.tab.h	View	1	4 chunks	+23 lines, -27 lines	0 comments	Download
M	src/cmd/8a/y.tab.c	View	1	55 chunks	+584 lines, -864 lines	0 comments	Download
M	src/cmd/cc/lexbody	View	1	5 chunks	+4 lines, -70 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-12-04 19:23:51 UTC) #1

iant

LGTM https://codereview.appspot.com/35830043/diff/60001/src/cmd/5a/a.h File src/cmd/5a/a.h (right): https://codereview.appspot.com/35830043/diff/60001/src/cmd/5a/a.h#newcode34 src/cmd/5a/a.h:34: Seems to add extraneous space.

11 years, 7 months ago (2013-12-06 00:03:26 UTC) #2

rsc

https://codereview.appspot.com/35830043/diff/60001/src/cmd/5a/a.h File src/cmd/5a/a.h (right): https://codereview.appspot.com/35830043/diff/60001/src/cmd/5a/a.h#newcode34 src/cmd/5a/a.h:34: On 2013/12/06 00:03:26, iant wrote: > Seems to add ...

11 years, 7 months ago (2013-12-09 03:39:19 UTC) #3

rsc

11 years, 7 months ago (2013-12-09 03:50:00 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=d245b1701154 ***

cmd/5a, cmd/6a, cmd/8a: use liblink

Preparation for golang.org/s/go13linker work.

This CL does not build by itself. It depends on 35740044
and 35790044 and will be submitted at the same time.

R=iant
CC=golang-dev
https://codereview.appspot.com/35830043

Expand All Messages | Collapse All Messages