Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1798)

Issue 3581041: Doc: Various to LM and NR from user email threads (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by pkx166h
Modified:
8 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Various to LM and NR from user email threads Staff.itely (NR) @knownissues that PianoStaff does not accept ChordNames http://lists.gnu.org/archive/html/lilypond-user/2010-09/msg00297.html Spacing.itely (NR) @warning that odd page numbers are always on the RH page and that you must have a blank second page if you want music to start on page '1' is you have a cover page http://lists.gnu.org/archive/html/lilypond-user/2010-06/msg00475.html editorial.itely (NR) @knownissue that using \teeny \tiny \small etc instead of explicit fontSize will produce inconsistent line spacing comparitively http://lists.gnu.org/archive/html/lilypond-user/2010-09/msg00665.html

Patch Set 1 #

Total comments: 19

Patch Set 2 : Changes to previous that there's concensus on. Editorial.itely edits moved to text.itely. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M Documentation/notation/spacing.itely View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Documentation/notation/staff.itely View 1 chunk +3 lines, -0 lines 0 comments Download
M Documentation/notation/text.itely View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14
Trevor Daniels
Hi James All good stuff. One suggested change to the wording to make it less ...
8 years, 6 months ago (2010-12-10 23:41:50 UTC) #1
Valentin Villenave
Greetings, it does improve things; there's just one sentence I'm not entirely happy with. http://codereview.appspot.com/3581041/diff/1/Documentation/notation/repeats.itely ...
8 years, 6 months ago (2010-12-10 23:56:07 UTC) #2
Carl
Looks mostly good. I'd recommend a change to the bar check / alternative ending issue. ...
8 years, 6 months ago (2010-12-11 00:36:28 UTC) #3
Graham Percival (old account)
Thanks for this! I've slightly modified the git-cl instructions, to include "make the CC list ...
8 years, 6 months ago (2010-12-11 14:01:10 UTC) #4
pkx166h
I hope this is the right method to have a discussion on Rietveld, I have ...
8 years, 6 months ago (2010-12-11 16:33:48 UTC) #5
Carl
On 2010/12/11 16:33:48, pkx166h wrote: > I hope this is the right method to have ...
8 years, 6 months ago (2010-12-11 16:57:48 UTC) #6
Valentin Villenave
http://codereview.appspot.com/3581041/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/notation/repeats.itely#newcode151 Documentation/notation/repeats.itely:151: of and in between the braces of the grouped ...
8 years, 6 months ago (2010-12-11 19:09:14 UTC) #7
pkx166h
Sorry I didn't read Graham;s comment first time round. http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely#newcode2113 Documentation/learning/fundamental.itely:2113: ...
8 years, 6 months ago (2010-12-11 20:34:20 UTC) #8
Neil Puttock
http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely#newcode2115 Documentation/learning/fundamental.itely:2115: no note heads are produced and so no Stem ...
8 years, 6 months ago (2010-12-11 22:56:02 UTC) #9
Graham Percival (old account)
Lots of good discussion here, but I'm finding a bit confusing. James, could you extract ...
8 years, 6 months ago (2010-12-12 16:27:10 UTC) #10
pkx166h
http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): http://codereview.appspot.com/3581041/diff/1/Documentation/learning/fundamental.itely#newcode2115 Documentation/learning/fundamental.itely:2115: no note heads are produced and so no Stem ...
8 years, 6 months ago (2010-12-12 20:40:10 UTC) #11
pkx166h
Is this ok to push? James
8 years, 6 months ago (2010-12-14 22:37:00 UTC) #12
Trevor Daniels
Looks fine to me.
8 years, 6 months ago (2010-12-14 22:45:26 UTC) #13
Graham Percival (old account)
8 years, 6 months ago (2010-12-14 22:48:29 UTC) #14
On 2010/12/14 22:45:26, Trevor Daniels wrote:
> Looks fine to me.

LGTM too.  James, could you send the git format-patch to Trevor, who will push
it for you?

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b