Issue 35800043: code review 35800043: runtime: remove cross-function jump in vlop_arm.s

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35800043: code review 35800043: runtime: remove cross-function jump in vlop_arm.s (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
minux1, r, iant

CC:
iant, r, minux1, golang-dev

Visibility:
Public.

Description

runtime: remove cross-function jump in vlop_arm.s The new linker will disallow this on arm (it is already disallowed on amd64 and 386) in order to be able to lay out each function separately. The restriction is only for jumps into the middle of a function; jumps to the beginning of a function remain fine. Prereq for linker cleanup (golang.org/s/go13linker).

Patch Set 1 #

Patch Set 2 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r e9b026452a20 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/pkg/runtime/vlop_arm.s	View	1 2 3	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 8 months ago (2013-12-04 19:23:41 UTC) #1

iant

LGTM https://codereview.appspot.com/35800043/diff/20001/src/pkg/runtime/vlop_arm.s File src/pkg/runtime/vlop_arm.s (right): https://codereview.appspot.com/35800043/diff/20001/src/pkg/runtime/vlop_arm.s#newcode266 src/pkg/runtime/vlop_arm.s:266: B out1 Do you need this branch to ...

11 years, 8 months ago (2013-12-04 20:03:03 UTC) #3

rsc

Thanks. https://codereview.appspot.com/35800043/diff/20001/src/pkg/runtime/vlop_arm.s File src/pkg/runtime/vlop_arm.s (right): https://codereview.appspot.com/35800043/diff/20001/src/pkg/runtime/vlop_arm.s#newcode266 src/pkg/runtime/vlop_arm.s:266: B out1 On 2013/12/04 20:03:04, iant wrote: > ...

11 years, 8 months ago (2013-12-05 02:38:11 UTC) #4

rsc

11 years, 7 months ago (2013-12-09 03:52:12 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=d09eadc33036 ***

runtime: remove cross-function jump in vlop_arm.s

The new linker will disallow this on arm
(it is already disallowed on amd64 and 386)
in order to be able to lay out each function
separately.

The restriction is only for jumps into the middle
of a function; jumps to the beginning of a function
remain fine.

Prereq for linker cleanup (golang.org/s/go13linker).

R=iant, r, minux.ma
CC=golang-dev
https://codereview.appspot.com/35800043

Expand All Messages | Collapse All Messages