Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159)

Issue 357930043: Doc: add markup objects overview (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Valentin Villenave
Modified:
3 years, 10 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: add markup objects overview Someone on -user has made me realize that there was room in the current NR for a (non-exhaustive) list of the different places where \markup may be used: https://lists.gnu.org/archive/html/lilypond-user/2019-01/msg00425.html Aaron Hill has provided a nice example, which I elaborated upon as http://lsr.di.unimi.it/LSR/Item?id=1084 and then Trevor D. convinced me that it could find its way into the NR itself. So, there.

Patch Set 1 #

Patch Set 2 : Typo: add space before @ref link. #

Total comments: 22

Patch Set 3 : Address Werner’s suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -5 lines) Patch
M Documentation/notation/text.itely View 1 2 5 chunks +156 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Valentin Villenave
Typo: add space before @ref link.
3 years, 10 months ago (2019-01-20 23:24:12 UTC) #1
lemzwerg
LGTM, with some minor issues. Thanks! https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/357930043/diff/20001/Documentation/notation/text.itely#newcode50 Documentation/notation/text.itely:50: @cindex Text objects ...
3 years, 10 months ago (2019-01-21 06:18:36 UTC) #2
Valentin Villenave
Thanks a lot Werner! You caught quite a few things I should have dealt with ...
3 years, 10 months ago (2019-01-24 20:39:09 UTC) #3
Valentin Villenave
Address Werner’s suggestions.
3 years, 10 months ago (2019-01-24 21:11:20 UTC) #4
Valentin Villenave
On 2019/01/24 21:11:20, Valentin Villenave wrote: > Address Werner’s suggestions. This is a rather trivial ...
3 years, 10 months ago (2019-01-28 20:07:19 UTC) #5
Valentin Villenave
3 years, 10 months ago (2019-02-01 15:17:17 UTC) #6
On 2019/01/28 20:07:19, Valentin Villenave wrote:
> if nobody has any further objection,
> I suggest pushing it onto the countdown list…

Pushed as
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?h=staging&id=e4996ee89...

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b