Issue 35790043: Fix FileStorageReader path

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35790043: Fix FileStorageReader path (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by wallyworld

Modified:
10 years, 5 months ago

Reviewers:
mp+197307, axw

Visibility:
Public.

Description

Fix FileStorageReader path If FileStorageReader is initialised with a relative path, it needs to turn that into an absolute path so that downstream things like tools retrieval works. https://code.launchpad.net/~wallyworld/juju-core/sync-tools-relative-path/+merge/197307 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/filestorage/filestorage.go	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	environs/filestorage/filestorage_test.go	View	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

On 2013/12/02 01:46:03, wallyworld wrote: > Please take a look. LGTM, assuming the unrestored chdir ...

10 years, 5 months ago (2013-12-02 01:54:24 UTC) #2

wallyworld

10 years, 5 months ago (2013-12-02 02:02:24 UTC) #3

On 2013/12/02 01:54:24, axw wrote:
> On 2013/12/02 01:46:03, wallyworld wrote:
> > Please take a look.
> 
> LGTM, assuming the unrestored chdir doesn't break any other tests.

Fixed.

Expand All Messages | Collapse All Messages