Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2807)

Issue 357760043: Issue 5381: Change intermediate PDF filename

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by trueroad
Modified:
4 months, 2 weeks ago
Reviewers:
dak, lemzwerg, Dan Eble, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5381/5: Change intermediate PDF filename for DocBook There was a possibility that intermediate PDFs are output as final PDFs since the intermediate filename is the same as the final filename. This commit makes change intermediate PDF filename for DocBook. By default dblatex uses temporary directory instead of current directory for build. Therefore, only by changing the output filename, the intermediate PDF is not generated as final PDF filename. Issue 5381/4: Change intermediate PDF filename for LaTeX There was a possibility that intermediate PDFs are output as final PDFs since the intermediate filename is the same as the final filename. This commit changes LaTeX output directory to a temporary directory. After generating the intermediate PDF, we remove the temporary directory. If LaTeX terminates in error, make terminates before removing the temporary directory and we can investigate LaTeX logs. Issue 5381/3: Change intermediate PDF filename for Texinfo There was a possibility that intermediate PDFs are output as final PDFs since the intermediate filename is the same as the final filename. This commit makes change intermediate PDF filename for Texinfo. Issue 5381/2: Integrate Texinfo texi2pdf rules This commit makes integrate texi2pdf rules with and without `-D web_version`. Issue 5381/1: Wrap lines

Patch Set 1 #

Patch Set 2 : s/intermediate/tmp/ and wrap lines #

Total comments: 6

Patch Set 3 : Use different dir for LaTeX etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -18 lines) Patch
M make/lilypond-book-rules.make View 1 2 2 chunks +30 lines, -10 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 2 1 chunk +25 lines, -8 lines 0 comments Download

Messages

Total messages: 12
lemzwerg
LGTM, thanks! Two minor suggestions: s/intermediate/tmp/, since this is shorter. Please wrap the extremely long ...
5 months ago (2018-07-14 06:49:26 UTC) #1
trueroad
s/intermediate/tmp/ and wrap lines
5 months ago (2018-07-14 07:33:34 UTC) #2
trueroad
Thank you for your reviewing. On 2018/07/14 06:49:26, lemzwerg wrote: > LGTM, thanks! > > ...
5 months ago (2018-07-14 07:38:49 UTC) #3
dak
https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf This appears to change the output ...
5 months ago (2018-07-14 07:43:14 UTC) #4
trueroad
Thank you for your reviewing. https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf On ...
5 months ago (2018-07-14 08:22:49 UTC) #5
Dan Eble
https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf On 2018/07/14 08:22:49, trueroad wrote: > ...
5 months ago (2018-07-14 10:21:51 UTC) #6
dak
On 2018/07/14 08:22:49, trueroad wrote: > Unfortunately, we cannnot specify an output filename for LaTeX. ...
5 months ago (2018-07-14 10:23:49 UTC) #7
Dan Eble
https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo-rules.make File stepmake/stepmake/texinfo-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo-rules.make#newcode70 stepmake/stepmake/texinfo-rules.make:70: ifeq ($(WEB_VERSION),yes) Is the only difference between the two ...
5 months ago (2018-07-14 10:31:33 UTC) #8
trueroad
Use different dir for LaTeX etc.
4 months, 4 weeks ago (2018-07-15 07:38:30 UTC) #9
trueroad
Thank you for your reviewing. https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf On ...
4 months, 4 weeks ago (2018-07-15 07:44:32 UTC) #10
Carl
On 2018/07/15 07:44:32, trueroad wrote: > Thank you for your reviewing. > > https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make > ...
4 months, 3 weeks ago (2018-07-20 16:25:00 UTC) #11
trueroad
4 months, 2 weeks ago (2018-07-26 13:35:32 UTC) #12
I've pushed to staging.

commit fcc7ab0697a64df3c3f5ad1132d5538fb5f69168
Date:   Sat Jul 14 16:31:09 2018 +0900

    Issue 5381/5: Change intermediate PDF filename for DocBook

commit 30243148d5db705a86b57b77e132b0298b04819c
Date:   Sat Jul 14 16:29:08 2018 +0900

    Issue 5381/4: Change intermediate PDF filename for LaTeX

commit 20bbfea59668d049f92114090547934571d0f08d
Date:   Sat Jul 14 16:18:50 2018 +0900

    Issue 5381/3: Change intermediate PDF filename for Texinfo

commit 41e74e4639cf367cb033ed2bfd6d2fc05dfcee0d
Date:   Sun Jul 15 09:45:12 2018 +0900

    Issue 5381/2: Integrate Texinfo texi2pdf rules

commit 22106b8475bdf603cd1f8030b975e9e345f225bf
Date:   Sat Jul 14 16:13:08 2018 +0900

    Issue 5381/1: Wrap lines
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b