Issue 5381: Change intermediate PDF filename

Issue 5381/5: Change intermediate PDF filename for DocBook

    There was a possibility that intermediate PDFs are output as final PDFs
    since the intermediate filename is the same as the final filename.

    This commit makes change intermediate PDF filename for DocBook.

    By default dblatex uses temporary directory
    instead of current directory for build.
    Therefore, only by changing the output filename,
    the intermediate PDF is not generated as final PDF filename.

Issue 5381/4: Change intermediate PDF filename for LaTeX

    There was a possibility that intermediate PDFs are output as final PDFs
    since the intermediate filename is the same as the final filename.

    This commit changes LaTeX output directory to a temporary directory.

    After generating the intermediate PDF,
    we remove the temporary directory.
    If LaTeX terminates in error,
    make terminates before removing the temporary directory
    and we can investigate LaTeX logs.

Issue 5381/3: Change intermediate PDF filename for Texinfo

    There was a possibility that intermediate PDFs are output as final PDFs
    since the intermediate filename is the same as the final filename.

    This commit makes change intermediate PDF filename for Texinfo.

Issue 5381/2: Integrate Texinfo texi2pdf rules

    This commit makes integrate texi2pdf rules
    with and without `-D web_version`.

Issue 5381/1: Wrap lines

[lemzwerg, 2018-07-14 06:49:26]

LGTM, thanks!

Two minor suggestions:

s/intermediate/tmp/, since this is shorter.

Please wrap the extremely long lines in the makefiles for improved readability.

[trueroad, 2018-07-14 07:33:34]

s/intermediate/tmp/ and wrap lines

[trueroad, 2018-07-14 07:38:49]

Thank you for your reviewing.

On 2018/07/14 06:49:26, lemzwerg wrote:
> LGTM, thanks!
> 
> Two minor suggestions:
> 
> s/intermediate/tmp/, since this is shorter.
> 
> Please wrap the extremely long lines in the makefiles for improved
readability.

Done.

[dak, 2018-07-14 07:43:14]

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
File make/lilypond-book-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf
This appears to change the output name after the fact.  It would still create
the output under the final name and when
a) some parallel Make goes looking for it, it will find it existing and new
b) the script aborts while the file is still there
the problem, if any, would likely persist, possibly with a smaller time window
for causing trouble.

I think that any solution predicated on USE_EXTRACTPDFMARK would require an
if/then/else construct rather than an if/then construct in order not to have
this kind of race condition built-in by producing a file with the final name,
then doing additional actions on it.

[trueroad, 2018-07-14 08:22:49]

Thank you for your reviewing.

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
File make/lilypond-book-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf
On 2018/07/14 07:43:14, dak wrote:
> This appears to change the output name after the fact.  It would still create
> the output under the final name and when
> a) some parallel Make goes looking for it, it will find it existing and new
> b) the script aborts while the file is still there
> the problem, if any, would likely persist, possibly with a smaller time window
> for causing trouble.
> 
> I think that any solution predicated on USE_EXTRACTPDFMARK would require an
> if/then/else construct rather than an if/then construct in order not to have
> this kind of race condition built-in by producing a file with the final name,
> then doing additional actions on it.

If I understand correctly,
GNU make deletes a target file that the recipe was supposed to update when
aborted.
https://www.gnu.org/software/make/manual/html_node/Interrupts.html#Interrupts

Unfortunately, we cannnot specify an output filename for LaTeX.
So the patch uses `mv` after outputting the target filename.

I have another idea like following.

```
$(outdir)/%.pdf_tmp:  $(outdir)/%.tex
	pdflatex $<
	mv $(outdir)/$*.pdf $@

$(outdir)/%.pdf:  $(outdir)/%.pdf_tmp
ifeq ($(USE_EXTRACTPDFMARK),yes)
	extractpdfmark -o $(outdir)/$*.pdfmark $<
	gs -sOutputFile=$@ $(outdir)/$*.pdfmark $<
else
	cp $< $@
endif
```
How about this?

[Dan Eble, 2018-07-14 10:21:51]

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
File make/lilypond-book-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf
On 2018/07/14 08:22:49, trueroad wrote:
> Unfortunately, we cannnot specify an output filename for LaTeX.

How about creating the intermediate file in a different directory?  Would that
solve the problem?

[dak, 2018-07-14 10:23:49]

On 2018/07/14 08:22:49, trueroad wrote:

> Unfortunately, we cannnot specify an output filename for LaTeX.

I thought -jobname works for that.  It also affects all temporary files,
however.

[Dan Eble, 2018-07-14 10:31:33]

https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo...
File stepmake/stepmake/texinfo-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo...
stepmake/stepmake/texinfo-rules.make:70: ifeq ($(WEB_VERSION),yes)
Is the only difference between the two long commands in these alternatives "-D
web_version"?  How about something like the following?

TEXI2PDF_WEB_VERSION_FLAGS :=
ifeq ($(WEB_VERSION),yes)
TEXI2PDF_WEB_VERSION_FLAGS += -D web_version
endif

$(outdir)/%.pdf: $(outdir)/%.texi [...]
        [...] $(TEXI2PDF_FLAGS) $(TEXI2PDF_WEB_VERSION_FLAGS) [...]

[trueroad, 2018-07-15 07:38:30]

Use different dir for LaTeX etc.

[trueroad, 2018-07-15 07:44:32]

Thank you for your reviewing.

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
File make/lilypond-book-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf
On 2018/07/14 10:21:51, Dan Eble wrote:
> On 2018/07/14 08:22:49, trueroad wrote:
> > Unfortunately, we cannnot specify an output filename for LaTeX.
> 
> How about creating the intermediate file in a different directory?  Would that
> solve the problem?
> 

Done.

https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo...
File stepmake/stepmake/texinfo-rules.make (right):

https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo...
stepmake/stepmake/texinfo-rules.make:70: ifeq ($(WEB_VERSION),yes)
On 2018/07/14 10:31:33, Dan Eble wrote:
> Is the only difference between the two long commands in these alternatives "-D
> web_version"?  How about something like the following?
> 
> TEXI2PDF_WEB_VERSION_FLAGS :=
> ifeq ($(WEB_VERSION),yes)
> TEXI2PDF_WEB_VERSION_FLAGS += -D web_version
> endif
> 
> $(outdir)/%.pdf: $(outdir)/%.texi [...]
>         [...] $(TEXI2PDF_FLAGS) $(TEXI2PDF_WEB_VERSION_FLAGS) [...]

Done.

[Carl, 2018-07-20 16:25:00]

On 2018/07/15 07:44:32, trueroad wrote:
> Thank you for your reviewing.
> 
>
https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
> File make/lilypond-book-rules.make (right):
> 
>
https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules....
> make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf
> On 2018/07/14 10:21:51, Dan Eble wrote:
> > On 2018/07/14 08:22:49, trueroad wrote:
> > > Unfortunately, we cannnot specify an output filename for LaTeX.
> >

I'm fine with the current solution of a different directory, but I think one can
specify an output filename for LaTeX.  At least in my makefiles I do with the
--jobname option

Thanks,

Carl

[trueroad, 2018-07-26 13:35:32]

I've pushed to staging.

commit fcc7ab0697a64df3c3f5ad1132d5538fb5f69168
Date:   Sat Jul 14 16:31:09 2018 +0900

    Issue 5381/5: Change intermediate PDF filename for DocBook

commit 30243148d5db705a86b57b77e132b0298b04819c
Date:   Sat Jul 14 16:29:08 2018 +0900

    Issue 5381/4: Change intermediate PDF filename for LaTeX

commit 20bbfea59668d049f92114090547934571d0f08d
Date:   Sat Jul 14 16:18:50 2018 +0900

    Issue 5381/3: Change intermediate PDF filename for Texinfo

commit 41e74e4639cf367cb033ed2bfd6d2fc05dfcee0d
Date:   Sun Jul 15 09:45:12 2018 +0900

    Issue 5381/2: Integrate Texinfo texi2pdf rules

commit 22106b8475bdf603cd1f8030b975e9e345f225bf
Date:   Sat Jul 14 16:13:08 2018 +0900

    Issue 5381/1: Wrap lines