Issue 3542042: Review: idiff & iv tweaks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3542042: Review: idiff & iv tweaks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by larrygritz

Modified:
13 years, 4 months ago

Reviewers:
oiio-dev

Base URL:
http://svn.openimageio.org/oiio/trunk/

Visibility:
Public.

Description

idiff and iv were self-defeatingly setting the ImageCache size even smaller than the default. Adjust to be more realistic for large images and typical RAM sizes. Furthermore, I noticed a couple bugs in idiff: (1) files with different number of MIPmap levels immediately failed, whereas they should have compared their top levels, and only fail if the "-a" flag was used; (2) some failure modes incorrectly printed a "PASS" message despite actually failing.

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -8 lines)			Patch
		src/idiff/idiff.cpp	View		3 chunks	+15 lines, -7 lines	0 comments	Download
		src/iv/imageviewer.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages