Remove the OS/local dependent error message checking in unittest

[Jisi Liu, 2010-12-09 14:52:55]

Hmm, I'm not sure if we should fix this one.

The error message expected in the unittest is locale dependent (generated by the
OS). So this test failed in my zh-CN windows 7 machine..

[kenton, 2010-12-09 18:31:44]

How about calling Subprocess::Win32ErrorMessage()
(google/protobuf/compiler/subprocess.h) to generate the expected message
from the expected error code?

On Thu, Dec 9, 2010 at 6:52 AM, <liujisi@google.com> wrote:

> Reviewers: kenton,
>
> Message:
> Hmm, I'm not sure if we should fix this one.
>
> The error message expected in the unittest is locale dependent
> (generated by the OS). So this test failed in my zh-CN windows 7
> machine..
>
>
>
> Please review this at http://codereview.appspot.com/3542041/
>
> Affected files:
>  M     src/google/protobuf/compiler/command_line_interface_unittest.cc
>
>
> Index: src/google/protobuf/compiler/command_line_interface_unittest.cc
> ===================================================================
> --- src/google/protobuf/compiler/command_line_interface_unittest.cc
> (revision 360)
> +++ src/google/protobuf/compiler/command_line_interface_unittest.cc
> (working copy)
> @@ -1140,9 +1140,7 @@
>       "--proto_path=$tmpdir error.proto");
>
>  #ifdef _WIN32
> -  ExpectErrorSubstring(
> -      "--badplug_out: prefix-gen-badplug: The system cannot find the file
> "
> -        "specified.");
> +  ExpectErrorSubstring("--badplug_out: prefix-gen-badplug:");
>  #else
>   // Error written to stdout by child process after exec() fails.
>   ExpectErrorSubstring(
>
>
>

[Jisi Liu, 2010-12-20 15:03:00]

Done, changed to use Subprocess::WinErrorMessage()

[kenton, 2010-12-20 18:22:28]

LGTM