LTE EPC upgrade

LTE EPC upgrade (from Manuel Requena)

ns-3 issue:  https://www.nsnam.org/bugzilla/show_bug.cgi?id=3022

[Tom Henderson, 2018-11-26 04:55:06]

Most of my comments are minor and should be easy to handle.  Here are a few not
inline with the code:

1) The main comment that I have is that I don't see the need to add
'lena-simple-epc-upgrade.cc' which has only small differences from
'lena-simple-epc.cc'.  I suggest to just make the small edits that you want on
'lena-simple-epc.cc'.

2) Can you please edit CHANGES.html to add an item about the new behavior
enabled by this patch?  What benefit or user impact do these modifications bring
to users (please state).

3) Could you please add a note (if it is not already there) to .rst
documentation that the underlying EPC network is IPv4 only, despite the ability
for EPC to handle IPv6 end-to-end from remote host to UE (if you agree that this
is a true statement).

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
src/lte/doc/source/lte-design.rst:3150: point-to-point NetDevice, addressed to
the appropiate SGW.
s/appropiate/appropriate

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
src/lte/doc/source/lte-design.rst:3155: the outmost IP header matches the SGW IP
address). The local delivery
s/outmost/outermost

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point...
File src/lte/helper/point-to-point-epc-helper.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point...
src/lte/helper/point-to-point-epc-helper.cc:398: //packetSocket.Install (enb);
should this code be deleted?

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-applica...
File src/lte/model/epc-mme-application.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-applica...
src/lte/model/epc-mme-application.cc:32: : m_gtpcUdpPort (2123)
suggest to add also here the comment //fixed by the standard

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
File src/lte/model/epc-pgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:169: * \param msg GTPv2-C Create Session
Request message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:175: * \param msg GTPv2-C Modify Bearer
Request message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:181: * \param msg GTPv2-C Delete Bearer
Command message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:187: * \param msg GTPv2-C Delete Bearer
Response message
\param packet

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:220: *
\param protocolNumber

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-applica...
File src/lte/model/epc-sgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-applica...
src/lte/model/epc-sgw-application.h:157: * \param header the GTP-C header
delete \param header in this and several other methods in this class

[Manuel Requena, 2018-12-14 12:07:44]

All comments have been fixed. For the general comments:

1) I removed 'lena-simple-epc-upgrade.cc' as it was based on an old
'lena-simple-epc.cc'

2) done.

3) It is explained in "S1-U and S5 (data plane)" where we explain the data flow.
Now I've added a point in the design choices:

 #. The Packet Data Network (PDN) type supported is both IPv4 and IPv6.
    In other words, the end-to-end connections between the UEs and the remote
    hosts can be IPv4 and IPv6. However, the networks between the core network
    elements (MME, SGWs and PGWs) are IPv4-only.

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
src/lte/doc/source/lte-design.rst:3150: point-to-point NetDevice, addressed to
the appropiate SGW.
On 2018/11/26 04:55:06, Tom Henderson wrote:
> s/appropiate/appropriate

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
src/lte/doc/source/lte-design.rst:3155: the outmost IP header matches the SGW IP
address). The local delivery
On 2018/11/26 04:55:06, Tom Henderson wrote:
> s/outmost/outermost

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point...
File src/lte/helper/point-to-point-epc-helper.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point...
src/lte/helper/point-to-point-epc-helper.cc:398: //packetSocket.Install (enb);
On 2018/11/26 04:55:06, Tom Henderson wrote:
> should this code be deleted?

Yes. Done

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-applica...
File src/lte/model/epc-mme-application.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-applica...
src/lte/model/epc-mme-application.cc:32: : m_gtpcUdpPort (2123)
On 2018/11/26 04:55:06, Tom Henderson wrote:
> suggest to add also here the comment //fixed by the standard

Done. Also in doxygen of epc-mme-application.h

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
File src/lte/model/epc-pgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:169: * \param msg GTPv2-C Create Session
Request message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:175: * \param msg GTPv2-C Modify Bearer
Request message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:181: * \param msg GTPv2-C Delete Bearer
Command message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:187: * \param msg GTPv2-C Delete Bearer
Response message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:220: *
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param protocolNumber

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-applica...
File src/lte/model/epc-sgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-applica...
src/lte/model/epc-sgw-application.h:157: * \param header the GTP-C header
On 2018/11/26 04:55:06, Tom Henderson wrote:
> delete \param header in this and several other methods in this class

Done.