Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 353810043: LTE EPC upgrade

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by Tom Henderson
Modified:
1 day, 9 hours ago
Reviewers:
Manuel Requena
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

LTE EPC upgrade (from Manuel Requena) ns-3 issue: https://www.nsnam.org/bugzilla/show_bug.cgi?id=3022

Patch Set 1 #

Total comments: 20
Unified diffs Side-by-side diffs Delta from patch set Stats (+4662 lines, -224 lines) Patch
M doc/models/Makefile View 4 chunks +10 lines, -1 line 0 comments Download
M src/lte/doc/Makefile View 2 chunks +5 lines, -1 line 0 comments Download
A src/lte/doc/source/figures/epc-data-flow-dl-with-split.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/epc-data-flow-ul-with-split.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/epc-topology-with-split.dia View Binary file 0 comments Download
M src/lte/doc/source/figures/helpers.seqdiag View 1 chunk +29 lines, -19 lines 0 comments Download
A src/lte/doc/source/figures/lte-epc-e2e-control-protocol-stack-with-split.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-epc-e2e-data-protocol-stack-with-split.dia View Binary file 0 comments Download
M src/lte/doc/source/figures/nas-attach.seqdiag View 1 chunk +20 lines, -19 lines 0 comments Download
M src/lte/doc/source/lte-design.rst View 13 chunks +163 lines, -101 lines 4 comments Download
M src/lte/doc/source/lte-references.rst View 1 chunk +1 line, -1 line 0 comments Download
A src/lte/examples/lena-simple-epc-upgrade.cc View 1 chunk +212 lines, -0 lines 0 comments Download
M src/lte/examples/wscript View 1 chunk +3 lines, -0 lines 0 comments Download
M src/lte/helper/point-to-point-epc-helper.h View 5 chunks +89 lines, -21 lines 0 comments Download
M src/lte/helper/point-to-point-epc-helper.cc View 17 chunks +188 lines, -54 lines 2 comments Download
A src/lte/model/epc-gtpc-header.h View 1 chunk +468 lines, -0 lines 0 comments Download
A src/lte/model/epc-gtpc-header.cc View 1 chunk +1225 lines, -0 lines 0 comments Download
A src/lte/model/epc-mme-application.h View 1 chunk +240 lines, -0 lines 0 comments Download
A src/lte/model/epc-mme-application.cc View 1 chunk +367 lines, -0 lines 2 comments Download
A src/lte/model/epc-pgw-application.h View 1 chunk +341 lines, -0 lines 10 comments Download
A src/lte/model/epc-pgw-application.cc View 1 chunk +507 lines, -0 lines 0 comments Download
A src/lte/model/epc-sgw-application.h View 1 chunk +284 lines, -0 lines 2 comments Download
A src/lte/model/epc-sgw-application.cc View 1 chunk +480 lines, -0 lines 0 comments Download
M src/lte/model/epc-tft.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lte/model/epc-tft.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/lte/test/epc-test-s1u-downlink.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M src/lte/test/epc-test-s1u-uplink.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-ue-measurements.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/wscript View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Tom Henderson
Most of my comments are minor and should be easy to handle. Here are a ...
2 weeks, 5 days ago (2018-11-26 04:55:06 UTC) #1
Manuel Requena
1 day, 9 hours ago (2018-12-14 12:07:44 UTC) #2
All comments have been fixed. For the general comments:

1) I removed 'lena-simple-epc-upgrade.cc' as it was based on an old
'lena-simple-epc.cc'

2) done.

3) It is explained in "S1-U and S5 (data plane)" where we explain the data flow.
Now I've added a point in the design choices:

 #. The Packet Data Network (PDN) type supported is both IPv4 and IPv6.
    In other words, the end-to-end connections between the UEs and the remote
    hosts can be IPv4 and IPv6. However, the networks between the core network
    elements (MME, SGWs and PGWs) are IPv4-only.

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
src/lte/doc/source/lte-design.rst:3150: point-to-point NetDevice, addressed to
the appropiate SGW.
On 2018/11/26 04:55:06, Tom Henderson wrote:
> s/appropiate/appropriate

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/doc/source/lte-design...
src/lte/doc/source/lte-design.rst:3155: the outmost IP header matches the SGW IP
address). The local delivery
On 2018/11/26 04:55:06, Tom Henderson wrote:
> s/outmost/outermost

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point...
File src/lte/helper/point-to-point-epc-helper.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/helper/point-to-point...
src/lte/helper/point-to-point-epc-helper.cc:398: //packetSocket.Install (enb);
On 2018/11/26 04:55:06, Tom Henderson wrote:
> should this code be deleted?

Yes. Done

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-applica...
File src/lte/model/epc-mme-application.cc (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-mme-applica...
src/lte/model/epc-mme-application.cc:32: : m_gtpcUdpPort (2123)
On 2018/11/26 04:55:06, Tom Henderson wrote:
> suggest to add also here the comment //fixed by the standard

Done. Also in doxygen of epc-mme-application.h

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
File src/lte/model/epc-pgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:169: * \param msg GTPv2-C Create Session
Request message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:175: * \param msg GTPv2-C Modify Bearer
Request message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:181: * \param msg GTPv2-C Delete Bearer
Command message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:187: * \param msg GTPv2-C Delete Bearer
Response message
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param packet

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-pgw-applica...
src/lte/model/epc-pgw-application.h:220: *
On 2018/11/26 04:55:06, Tom Henderson wrote:
> \param protocolNumber

Done.

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-applica...
File src/lte/model/epc-sgw-application.h (right):

https://codereview.appspot.com/353810043/diff/1/src/lte/model/epc-sgw-applica...
src/lte/model/epc-sgw-application.h:157: * \param header the GTP-C header
On 2018/11/26 04:55:06, Tom Henderson wrote:
> delete \param header in this and several other methods in this class

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b