Completion_*_engraver: add means to preserve scale factor; issue 3650

Completion_*_engraver: add means to preserve scale factor; issue 3650

[benko.pal, 2013-11-30 10:38:20]

LGTM

[dak, 2013-11-30 11:08:26]

https://codereview.appspot.com/35370043/diff/1/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

https://codereview.appspot.com/35370043/diff/1/scm/define-context-properties....
scm/define-context-properties.scm:231: original duration to be split, and the
length of the measure.")
The description does not correspond to the actual function arguments.  The
function arguments, in addition, seem like a random collection of things that
could prove useful or not.

If there is more than one argument (the duration), then the only other argument
that seems to make sense to pass is the context: then context properties like
measureLength are available anyway.

Parametrization via additional context properties seems excessive, again
basically because such properties would be a random collection of things that
could prove useful or not.  Instead it would make sense to parameterize the
offered callback functions into closures, like

(define-public ((complete-on-multiples base) context duration)
  ...)

(no attempt to pick a good name here).  Then there is just one context variable
to override, after all.

[Keith, 2013-12-01 00:00:34]

On 2013/11/30 11:08:26, dak wrote:

> If there is more than one argument (the duration), then the only other
argument
> that seems to make sense to pass is the context: then context properties like
> measureLength are available anyway.
> 

That makes sense.

[benko.pal, 2013-12-01 08:00:10]

LSTGM