Issue 35330043: code review 35330043: cmd/yacc: expr example support windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 35330043: code review 35330043: cmd/yacc: expr example support windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by chai2010

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/yacc: expr example support windows 1. expr append executable extension. 2. support '\r' character. Fixes issue 6851.

Patch Set 2 : diff -r bddf2a72f5e1 http://code.google.com/p/go/ #

Patch Set 3 : diff -r bddf2a72f5e1 http://code.google.com/p/go/ #

Total comments: 4

Patch Set 4 : diff -r c7958a17fab8 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/cmd/yacc/Makefile	View	1 2 3	1 chunk	+5 lines, -3 lines	0 comments	Download
	M	src/cmd/yacc/expr.y	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

chai2010

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go/

11 years, 7 months ago (2013-11-30 03:22:37 UTC) #1

rsc

https://codereview.appspot.com/35330043/diff/40001/src/cmd/yacc/Makefile File src/cmd/yacc/Makefile (right): https://codereview.appspot.com/35330043/diff/40001/src/cmd/yacc/Makefile#newcode5 src/cmd/yacc/Makefile:5: NAME=expr Please drop this and leave expr in the ...

11 years, 7 months ago (2013-12-18 17:52:21 UTC) #2

chai2010

PTAL https://codereview.appspot.com/35330043/diff/40001/src/cmd/yacc/Makefile File src/cmd/yacc/Makefile (right): https://codereview.appspot.com/35330043/diff/40001/src/cmd/yacc/Makefile#newcode5 src/cmd/yacc/Makefile:5: NAME=expr On 2013/12/18 17:52:21, rsc wrote: > Please ...

11 years, 7 months ago (2013-12-19 01:18:56 UTC) #3

rsc

11 years, 7 months ago (2013-12-19 17:14:10 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=4300161e0f2a ***

cmd/yacc: expr example support windows

1. expr append executable extension.
2. support '\r' character.

Fixes issue 6851.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/35330043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages