Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(54)

Issue 351720043: Spacing_spanner::prune_loose_columns: prune in-place

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by dak
Modified:
1 week, 2 days ago
Reviewers:
benko.pal, Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Spacing_spanner::prune_loose_columns: prune in-place This saves a tiny amount of time and memory.

Patch Set 1 #

Patch Set 2 : Cater to C++98 #

Patch Set 3 : I am stupid #

Patch Set 4 : Add a comment according to Pál's suggestion even though it turns out his suggestion would have wor… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M lily/spacing-determine-loose-columns.cc View 1 2 3 3 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 8
Dan Eble
LGTM
4 weeks, 1 day ago (2018-06-19 23:55:10 UTC) #1
benko.pal
LGTM; just by looking I can't see how it can make make fail. using rp[-2] ...
1 week, 2 days ago (2018-07-10 17:10:53 UTC) #2
dak
On 2018/07/10 17:10:53, benko.pal wrote: > LGTM; just by looking I can't see how it ...
1 week, 2 days ago (2018-07-10 17:49:33 UTC) #3
dak
On 2018/07/10 17:49:33, dak wrote: > On 2018/07/10 17:10:53, benko.pal wrote: > > LGTM; just ...
1 week, 2 days ago (2018-07-10 18:09:19 UTC) #4
dak
Cater to C++98
1 week, 2 days ago (2018-07-10 18:24:39 UTC) #5
dak
I am stupid
1 week, 2 days ago (2018-07-10 19:10:47 UTC) #6
benko.pal
On 2018/07/10 18:09:19, dak wrote: > On 2018/07/10 17:49:33, dak wrote: > > On 2018/07/10 ...
1 week, 2 days ago (2018-07-10 19:29:30 UTC) #7
dak
1 week, 2 days ago (2018-07-10 20:27:28 UTC) #8
Add a comment according to Pál's suggestion even though it turns out his
suggestion would have worked after all for even more contorted reasons
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b