Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 35110043: code review 35110043: gosshnew/ssh: Pubkey client auth now should return []Signer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by hanwen-google
Modified:
7 years, 10 months ago
Reviewers:
agl1, jpsugar
CC:
agl1, dfc, jpsugar, golang-dev, hanwen-google
Visibility:
Public.

Description

gosshnew/ssh: pubkey client-side auth now returns []Signer.

Patch Set 1 #

Patch Set 2 : diff -r 14ed64f25713 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 3 : diff -r 14ed64f25713 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Total comments: 10

Patch Set 4 : diff -r 14ed64f25713 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Patch Set 5 : diff -r 14ed64f25713 https://hanwen%40google.com@code.google.com/p/gosshnew/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -78 lines) Patch
M ssh/client_auth.go View 1 2 3 4 chunks +42 lines, -56 lines 0 comments Download
M ssh/client_auth_test.go View 1 3 chunks +7 lines, -12 lines 0 comments Download
M ssh/test/test_unix_test.go View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7
hanwen-google
Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org, dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com, jpsugar@google.com), I'd like you to review ...
7 years, 11 months ago (2013-11-29 11:18:27 UTC) #1
jpsugar
LGTM https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode219 ssh/client_auth.go:219: s := serializeSignature(pub.PublicKeyAlgo(), sign) algoname?
7 years, 11 months ago (2013-12-02 18:30:32 UTC) #2
agl1
https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159 ssh/client_auth.go:159: Signers() ([]Signer, error) As ever with a one-element interface, ...
7 years, 11 months ago (2013-12-02 18:38:04 UTC) #3
hanwen-google
https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159 ssh/client_auth.go:159: Signers() ([]Signer, error) On 2013/12/02 18:38:04, agl1 wrote: > ...
7 years, 11 months ago (2013-12-03 09:59:10 UTC) #4
agl1
LGTM https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159 ssh/client_auth.go:159: Signers() ([]Signer, error) On 2013/12/03 09:59:11, hanwen-google wrote: ...
7 years, 11 months ago (2013-12-03 15:29:26 UTC) #5
hanwen-google
https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go File ssh/client_auth.go (right): https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159 ssh/client_auth.go:159: Signers() ([]Signer, error) On 2013/12/03 15:29:26, agl1 wrote: > ...
7 years, 11 months ago (2013-12-03 15:36:41 UTC) #6
hanwen-google
7 years, 11 months ago (2013-12-03 15:44:15 UTC) #7
*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=4b6c2dde8ede
***

gosshnew/ssh: pubkey client-side auth now returns []Signer.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/35110043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b