code review 35070044: freetype/truetype: apply the pp1x adjustment to the unh...

freetype/truetype: apply the pp1x adjustment to the unhinted points
*before* hinting.

[nigeltao, 2013-11-29 10:10:44]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com,
remyoudompheng@gmail.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-11-29 11:08:39]

LGTM
On ven., nov. 29, 2013 at 11:10 AM, <nigeltao@golang.org> wrote:

> Reviewers: bsiegert,
>
> Message:
> Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com,
> remyoudompheng@gmail.com),
>
> I'd like you to review this change to
> https://code.google.com/p/freetype-go
>
>
> Description:
> freetype/truetype: apply the pp1x adjustment to the unhinted points
> *before* hinting.
>
> Please review this at https://codereview.appspot.com/35070044/
>
> Affected files (+2, -2 lines):
>    M freetype/truetype/glyph.go
>    M freetype/truetype/truetype_test.go
>
>
> Index: freetype/truetype/glyph.go
> ===================================================================
> --- a/freetype/truetype/glyph.go
> +++ b/freetype/truetype/glyph.go
> @@ -394,7 +394,6 @@
>                 p.Y = g.font.scale(g.scale * p.Y)
>         }
>         if simple && g.hinter != nil {
> -               g.Unhinted = append(g.Unhinted, g.Point[np0:]...)
>                 // Round the 1st phantom point to the grid, shifting all
> other points
> equally.
>                 pp1x := g.Point[len(g.Point)-4].X
>                 if dx := ((pp1x + 32) &^ 63) - pp1x; dx != 0 {
> @@ -402,6 +401,7 @@
>                                 g.Point[i].X += dx
>                         }
>                 }
> +               g.Unhinted = append(g.Unhinted, g.Point[np0:]...)
>         }
>         // Round the 2nd and 4th phantom point to the grid.
>         p := &g.Point[len(g.Point)-3]
> Index: freetype/truetype/truetype_test.go
> ===================================================================
> --- a/freetype/truetype/truetype_test.go
> +++ b/freetype/truetype/truetype_test.go
> @@ -255,7 +255,7 @@
>         hintingBrokenAt int
>   }{
>         {"luxisr", 12, -1},
> -       {"x-arial-bold", 11, 130},
> +       {"x-arial-bold", 11, 238},
>         {"x-deja-vu-sans-oblique", 17, -1},
>         {"x-droid-sans-japanese", 9, 0},
>         {"x-times-new-roman", 13, 0},
>
>
>

[nigeltao, 2013-11-29 11:13:07]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=97c47fe576fa ***

freetype/truetype: apply the pp1x adjustment to the unhinted points
*before* hinting.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/35070044