Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 35060046: let RhythmicStaff use default barline extent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by janek
Modified:
10 years, 5 months ago
Reviewers:
Keith
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

let RhythmicStaff use default barline extent There is no reason to make barlines in RhythmicStaff special. The purpose of the deleted code was probably to ensure that the barlines were visible at all (despite the fact that there is just one staffline in a RhythmicStaff). However, currently barline code takes care of this by default. This makes barlines in DrumStaff and RhythmicStaff similar.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ly/engraver-init.ly View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
Keith
Looks good. Repeat bars look fine (as they do in Drum Staff). The book by ...
10 years, 5 months ago (2013-11-30 05:56:50 UTC) #1
janek
On 2013/11/30 05:56:50, Keith wrote: > Looks good. > > Repeat bars look fine (as ...
10 years, 5 months ago (2013-12-01 12:28:12 UTC) #2
janek
10 years, 5 months ago (2013-12-04 23:01:39 UTC) #3
Message was sent while issue was closed.
pushed as e8a9ef10aa3bfc2db7689aa58631aabb4095cd16

cheers,
JAnek :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b