Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 349790043: Disable multiprocessing (threading-only) under Alpine Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 4 weeks ago by Mike Schwartz
Modified:
1 month, 2 weeks ago
Reviewers:
houglum
CC:
tjennison_google.com, gsutil-crs_google.com
Visibility:
Public.

Description

Disable multiprocessing (threading-only) under Alpine Linux

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 4

Patch Set 3 : Changes per review comments #

Total comments: 7

Patch Set 4 : Fix config generation #

Patch Set 5 : more review comments #

Total comments: 2

Patch Set 6 : fix missing logging import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M gslib/utils/parallelism_framework_util.py View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10
Mike Schwartz
1 month, 4 weeks ago (2018-10-12 00:02:13 UTC) #1
houglum
A couple comments, PTAL. FYI for discussion contributors: this review was not created with the ...
1 month, 4 weeks ago (2018-10-12 08:28:13 UTC) #2
Mike Schwartz
https://codereview.appspot.com/349790043/diff/20001/gslib/command.py File gslib/command.py (right): https://codereview.appspot.com/349790043/diff/20001/gslib/command.py#newcode1377 gslib/command.py:1377: if RunningOnAlpineLinux(): On 2018/10/12 08:28:13, houglum wrote: > So, ...
1 month, 4 weeks ago (2018-10-12 18:50:14 UTC) #3
houglum
https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py File gslib/utils/parallelism_framework_util.py (right): https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py#newcode254 gslib/utils/parallelism_framework_util.py:254: raise IOError('Unable to open /etc/os-release to determine OS release') ...
1 month, 4 weeks ago (2018-10-12 21:47:23 UTC) #4
Mike Schwartz
https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py File gslib/utils/parallelism_framework_util.py (right): https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py#newcode254 gslib/utils/parallelism_framework_util.py:254: raise IOError('Unable to open /etc/os-release to determine OS release') ...
1 month, 4 weeks ago (2018-10-12 22:06:34 UTC) #5
houglum
https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py File gslib/utils/parallelism_framework_util.py (right): https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py#newcode254 gslib/utils/parallelism_framework_util.py:254: raise IOError('Unable to open /etc/os-release to determine OS release') ...
1 month, 4 weeks ago (2018-10-12 23:07:34 UTC) #6
Mike Schwartz
https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py File gslib/utils/parallelism_framework_util.py (right): https://codereview.appspot.com/349790043/diff/40001/gslib/utils/parallelism_framework_util.py#newcode254 gslib/utils/parallelism_framework_util.py:254: raise IOError('Unable to open /etc/os-release to determine OS release') ...
1 month, 4 weeks ago (2018-10-12 23:18:42 UTC) #7
houglum
https://codereview.appspot.com/349790043/diff/80001/gslib/utils/parallelism_framework_util.py File gslib/utils/parallelism_framework_util.py (right): https://codereview.appspot.com/349790043/diff/80001/gslib/utils/parallelism_framework_util.py#newcode254 gslib/utils/parallelism_framework_util.py:254: logger.debug('Unable to open /etc/os-release to determine whether OS ' ...
1 month, 4 weeks ago (2018-10-12 23:36:33 UTC) #8
Mike Schwartz
https://codereview.appspot.com/349790043/diff/80001/gslib/utils/parallelism_framework_util.py File gslib/utils/parallelism_framework_util.py (right): https://codereview.appspot.com/349790043/diff/80001/gslib/utils/parallelism_framework_util.py#newcode254 gslib/utils/parallelism_framework_util.py:254: logger.debug('Unable to open /etc/os-release to determine whether OS ' ...
1 month, 4 weeks ago (2018-10-13 00:00:24 UTC) #9
houglum
1 month, 3 weeks ago (2018-10-13 02:24:27 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b