Issue 349080043: Issue 5218: document footnote-separator-markup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 349080043: Issue 5218: document footnote-separator-markup

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 3 months ago by Malte Meyn

Modified:
5 years, 3 months ago

Reviewers:
thomasmorley651

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 5218: document footnote-separator-markup

Patch Set 1 #

Total comments: 2

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	Documentation/notation/input.itely	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	Documentation/notation/spacing.itely	View		1 chunk	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

thomasmorley651

5 years, 3 months ago (2019-01-05 11:05:31 UTC) #1

Some nits:

https://codereview.appspot.com/349080043/diff/1/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):

https://codereview.appspot.com/349080043/diff/1/Documentation/notation/spacin...
Documentation/notation/spacing.itely:1082: bottom of the page.  Default: a
centered horizontal line.
I'd go for:
Default: a centered horizontal line, defined in @file{ly/paper-defaults-init.ly}

https://codereview.appspot.com/349080043/diff/1/Documentation/notation/spacin...
Documentation/notation/spacing.itely:1088: @file{ly/titling-init.ly}.
And add here:
@file{ly/paper-defaults-init.ly}

Expand All Messages | Collapse All Messages