Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Issue 348940044: Issue 5340: Simplify Spacing_spanner::get_columns (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by Dan Eble
Modified:
4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5340/ The old algorithm filtered the system's list of columns into a list of used columns, then searched the filtered list for the endpoints of the range to return. The search key was the "rank" of a column, which is its index in the unfiltered list of columns (see System::add_column). There is therefore no need to search. The new algorithm selects the desired range in the unfiltered list and then filters that. This commit also removes the unused function Paper_column::compare. I am assuming that this area of the code is well covered by the regression tests. I have not put any effort into verifying coverage.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M lily/include/paper-column.hh View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/include/spacing-spanner.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/system.hh View 2 chunks +7 lines, -1 line 0 comments Download
M lily/paper-column.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M lily/spacing-spanner.cc View 1 chunk +15 lines, -11 lines 0 comments Download
M lily/system.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b