Issue 34890044: cmd/juju/addmachine.go: first part of compat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 34890044: cmd/juju/addmachine.go: first part of compat

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by jameinel

Modified:
10 years, 5 months ago

Reviewers:
mp+197114, axw

Visibility:
Public.

Description

cmd/juju/addmachine.go: first part of compat This handles the part of add-machine that doesn't involve manual provisioning. It makes trunk compatible with 1.16.3 for a simple "juju add-machine" or "juju add-machine lxc". The manual provisioning case has a bunch more code, so that will be a followup patch. https://code.launchpad.net/~jameinel/juju-core/1.17-add-machine-compat-1253631/+merge/197114 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -7 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/juju/addmachine.go	View		3 chunks	+50 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 5 months ago (2013-11-29 00:45:22 UTC) #2

On 2013/11/28 20:21:12, jameinel wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages