Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(584)

Issue 348760043: Issue 5318: Context regression tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by Dan Eble
Modified:
2 months, 3 weeks ago
Reviewers:
carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5318/ Note that context-find-parent.ly currently fails.

Patch Set 1 #

Patch Set 2 : stop relying on duplicating type+ID #

Patch Set 3 : remove stray character from comment #

Patch Set 4 : restore IDs #

Patch Set 5 : revise instrument names for clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -0 lines) Patch
A input/regression/context-find-child.ly View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A input/regression/context-find-current.ly View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A input/regression/context-find-grandchild.ly View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download
A input/regression/context-find-grandchild-ambiguous.ly View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A input/regression/context-find-parent.ly View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A input/regression/context-find-score-alias.ly View 1 chunk +10 lines, -0 lines 0 comments Download
A input/regression/context-find-sibling.ly View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
A input/regression/context-global-find.ly View 1 chunk +20 lines, -0 lines 0 comments Download
A input/regression/context-global-new.ly View 1 chunk +20 lines, -0 lines 0 comments Download
A input/regression/context-global-set.ly View 1 chunk +18 lines, -0 lines 0 comments Download
A input/regression/context-new-child-same-name.ly View 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A input/regression/context-new-sibling-same-name.ly View 2 3 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10
Dan Eble
I would appreciate a close review of these tests by at least one of the ...
3 months, 2 weeks ago (2018-05-03 02:48:10 UTC) #1
Carl
On 2018/05/03 02:48:10, Dan Eble wrote: > I would appreciate a close review of these ...
3 months, 2 weeks ago (2018-05-03 12:40:17 UTC) #2
Dan Eble
On 2018/05/03 12:40:17, Carl wrote: > In my opinion, the most ideal result when one ...
3 months, 2 weeks ago (2018-05-04 16:48:36 UTC) #3
Dan Eble
stop relying on duplicating type+ID
3 months, 1 week ago (2018-05-07 22:53:29 UTC) #4
Dan Eble
remove stray character from comment
3 months, 1 week ago (2018-05-07 22:56:59 UTC) #5
Dan Eble
On 2018/05/07 22:53:29, Dan Eble wrote: > stop relying on duplicating type+ID Carl, I hope ...
3 months, 1 week ago (2018-05-07 23:07:36 UTC) #6
Carl
On 2018/05/07 23:07:36, Dan Eble wrote: > On 2018/05/07 22:53:29, Dan Eble wrote: > > ...
3 months, 1 week ago (2018-05-12 20:46:54 UTC) #7
Dan Eble
restore IDs
3 months, 1 week ago (2018-05-13 02:08:26 UTC) #8
Dan Eble
revise instrument names for clarity
3 months, 1 week ago (2018-05-13 02:10:16 UTC) #9
Dan Eble
3 months, 1 week ago (2018-05-13 18:07:15 UTC) #10
I no longer plan to push context-global-*.ly, though I won't refresh the code
review for it.

By the time I'm done with some changes I'm working on, I think I'll have to
overhaul those cases to take a different approach.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b