Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1571)

Issue 348050043: Issue 4396

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by Malte Meyn
Modified:
8 months, 1 week ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4396 This adds the command \ambitusAfterKeySignature to property-init.ly. I’m not sure whether that’s the correct place, please review. The command can be placed in a \layout block but not in \layout { \context { \Staff … } } because it’s an override on Score level. Maybe it should be a context mod (\with { … }) instead of music expression? The suggested change also improves ambitus’s horizontal spacing.

Patch Set 1 #

Total comments: 2

Patch Set 2 : more versatile \ambitusAfter, added regtest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
A input/regression/ambitus-position.ly View 1 1 chunk +30 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 1 chunk +17 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 3
Malte Meyn
This doesn’t change LilyPond’s default behaviour (well, except for some slight horizontal spacing changes; the ...
8 months, 1 week ago (2018-12-15 10:40:36 UTC) #1
dak
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly#newcode34 ly/property-init.ly:34: ambitusAfterKeySignature = { On 2018/12/15 10:40:36, Malte Meyn wrote: ...
8 months, 1 week ago (2018-12-15 10:58:19 UTC) #2
Malte Meyn
8 months, 1 week ago (2018-12-15 16:37:35 UTC) #3
more versatile \ambitusAfter, added regtest
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b