Code review - Issue 348050043: Issue 4396https://codereview.appspot.com/2018-12-15T16:37:35+00:00rietveld
Message from unknown
2018-12-12T13:53:10+00:00Malte Meynurn:md5:b45590932ef40278e3700b2ddbbb93b1
Message from lilypond@maltemeyn.de
2018-12-15T10:40:36+00:00Malte Meynurn:md5:89158fac4958a8b802ba1878ed39c553
This doesn’t change LilyPond’s default behaviour (well, except for some slight horizontal spacing changes; the Ambitus hadn’t been centered between LeftEdge and Clef). Should it because Ambitus after the KeySignature makes more sense (looking at accidentals …) for some people?
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly#newcode34
ly/property-init.ly:34: ambitusAfterKeySignature = {
Is this the correct file for such a command? Also, I’m not sure whether that’s the best name, it seems very long to me.
Message from dak@gnu.org
2018-12-15T10:58:19+00:00dakurn:md5:03c529b5b50bbb008a1f20a555cee944
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly
File ly/property-init.ly (right):
https://codereview.appspot.com/348050043/diff/1/ly/property-init.ly#newcode34
ly/property-init.ly:34: ambitusAfterKeySignature = {
On 2018/12/15 10:40:36, Malte Meyn wrote:
> Is this the correct file for such a command? Also, I’m not sure whether that’s
> the best name, it seems very long to me.
This looks like something that might rather warrant an applyContext and take an argument such as
\ambitusAfter key-signature
\ambitusAfter time-signature
since then it would combine with other changes of break-align-orders.
Message from unknown
2018-12-15T16:37:33+00:00Malte Meynurn:md5:e653a8a72acdb0f7aa769e8c010cc56a
Message from lilypond@maltemeyn.de
2018-12-15T16:37:35+00:00Malte Meynurn:md5:8bc6fa5db9506253cb908296d4e8cfd5
more versatile \ambitusAfter, added regtest