Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2932)

Issue 347930043: fingering-engraver.cc: don't set Fingering.pitch

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by dak
Modified:
4 months, 1 week ago
Reviewers:
lemzwerg, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

fingering-engraver.cc: don't set Fingering.pitch This grob property does not actually exist.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M lily/fingering-engraver.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM. I suggest that you do such trivial clean-ups directly in the git repository, not ...
4 months, 1 week ago (2018-08-03 03:24:40 UTC) #1
dak
On 2018/08/03 03:24:40, lemzwerg wrote: > LGTM. I suggest that you do such trivial clean-ups ...
4 months, 1 week ago (2018-08-03 06:52:29 UTC) #2
hanwenn
LGTM
4 months, 1 week ago (2018-08-03 08:25:32 UTC) #3
dak
4 months, 1 week ago (2018-08-03 08:51:12 UTC) #4
On 2018/08/03 08:25:32, hanwenn wrote:
> LGTM

Thanks.  For the record, I am currently renaming get_property and set_property
for grobs since I want to change their internals in a manner not compatible with
the existing get_property macro (which does not get to know what kind of class
it is being used on).  So I did a rename job for all known grob properties
(quite a nuisance because probably 15% of stuff like "direction" or "text" ended
up not being a grob property after all) and cleaned up afterwards.  And a few
things just didn't clean up.

This is one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b