Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 347870043: Fix out-of-sync LilyScriptEncoding / ps script defs

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by knupero
Modified:
2 months, 1 week ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix out-of-sync LilyScriptEncoding / ps script defs Commit 12fe78825798191ecb7e5a4ee3064679773ae1ab broke encodingdefs.ps. This patch will not pass 'make check', but this is ok as the current state is wrong. I did not care about the 80-characters per line limit, it is easier to maintain this format. The glyphs are now included in the order in which they are included in the emmentaler fonts. The order of the glyphs does not matter as long as the encoding vector and the corresponding commands match. The change occured because I decided to use otfinfo and sed to generate the new code, it seemed easier, safer and faster than correcting the old code by hand. Signed-off-by: Knut Petersen <knut_petersen@t-online.de>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -219 lines) Patch
M ps/encodingdefs.ps View 1 chunk +172 lines, -219 lines 0 comments Download

Messages

Total messages: 3
knupero
Please review.
2 months, 1 week ago (2018-06-08 09:54:29 UTC) #1
dak
On 2018/06/08 09:54:29, knupero wrote: > Please review. When you say "will not pass make ...
2 months, 1 week ago (2018-06-08 10:29:40 UTC) #2
knupero
2 months, 1 week ago (2018-06-08 10:33:09 UTC) #3
On 2018/06/08 10:29:40, dak wrote:
> On 2018/06/08 09:54:29, knupero wrote:
> > Please review.
> 
> When you say "will not pass make check", you mean that there are visual
> differences, not that the test aborts, right?  Since the latter would not be
ok.

Exactly. There is an intended visual difference, but 'make test' runs fine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b