Issue 34750043: cmd/juju/environ.go: restore 1.16 compat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 34750043: cmd/juju/environ.go: restore 1.16 compat

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by jameinel

Modified:
10 years, 5 months ago

Reviewers:
axw, mp+197059

Visibility:
Public.

Description

cmd/juju/environ.go: restore 1.16 compat bug #1253625 is about "juju get-environment" and "juju set-environment" not being compatible with a 1.16 API server because Client.EnvironmentGet and Client.EnvironmentSet were not available. So we fall back to direct DB access. This replaces 'all' of SetEnvironment.Run because it has virtually no other local logic. For GetEnvironment.Run we only replace the EnvironmentGet step. (hence the different names for the functions.) https://code.launchpad.net/~jameinel/juju-core/1.17-set-get-environment-compat-1253625/+merge/197059 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	cmd/juju/environment.go	View		5 chunks	+67 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 5 months ago (2013-11-29 01:00:18 UTC) #2

On 2013/11/28 12:53:09, jameinel wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages