Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(571)

Issue 346810043: Allow Scheme/identifiers for duration multipliers

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by dak
Modified:
1 year, 6 months ago
Reviewers:
thomasmorley651, carl.d.sorensen, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow Scheme/identifiers for duration multipliers Also contains commit: Regtest for computed duration multipliers

Patch Set 1 #

Patch Set 2 : No good dead goes unpunished. Documentation and harmonization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -26 lines) Patch
M Documentation/notation/rhythms.itely View 1 3 chunks +13 lines, -7 lines 0 comments Download
A input/regression/duration-multiplier-scheme.ly View 1 1 chunk +31 lines, -0 lines 0 comments Download
M lily/include/lily-imports.hh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lily/include/music.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/music-sequence.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/lily-imports.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lily/music.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lily/music-scheme.cc View 1 1 chunk +7 lines, -9 lines 0 comments Download
M lily/music-sequence.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/parser.yy View 1 2 chunks +15 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 3 chunks +4 lines, -5 lines 0 comments Download
M scm/c++.scm View 1 1 chunk +12 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
thomasmorley651
From description and regtest: very nice. Will it work for below as well? #(define frac ...
1 year, 6 months ago (2018-05-22 21:05:59 UTC) #1
Carl
LGreatTM! You have a way af making changes to the parser seem obvious, when they ...
1 year, 6 months ago (2018-05-22 21:17:44 UTC) #2
dak
On 2018/05/22 21:05:59, thomasmorley651 wrote: > From description and regtest: very nice. > > Will ...
1 year, 6 months ago (2018-05-22 21:32:18 UTC) #3
dak
No good dead goes unpunished. Documentation and harmonization.
1 year, 6 months ago (2018-05-23 21:59:30 UTC) #4
Trevor Daniels
1 year, 6 months ago (2018-05-23 22:18:39 UTC) #5
The proposed documentation looks fine to me.

Trevor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b