Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(748)

Issue 346750043: Issue 5309: Refactor Context::get_score_context () (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Dan Eble
Modified:
5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5309/ Global_context::get_score_context () returns the first child, as before, but it is no longer a virtual method of Context. Translator::find_score_context () finds the Score context enclosing the Translator in a way similar to (but slightly more direct than) \set Score.whatever = ... rather than depending on the global context.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M lily/bar-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/context.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M lily/double-percent-repeat-engraver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M lily/forbid-break-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/global-context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/context.hh View 1 chunk +0 lines, -1 line 0 comments Download
M lily/include/global-context.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/translator.hh View 2 chunks +3 lines, -1 line 0 comments Download
M lily/ligature-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-column-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spanner-break-forbid-engraver.cc View 1 chunk +1 line, -3 lines 0 comments Download
M lily/translator.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Dan Eble
2 years, 1 month ago (2018-04-21 18:40:18 UTC) #1
Dan Eble
On 2018/04/21 18:40:18, Dan Eble wrote: This will deserve some revision based on questions to ...
2 years, 1 month ago (2018-04-25 22:40:26 UTC) #2
Dan Eble
5 months ago (2020-01-03 16:08:22 UTC) #3
On 2018/04/25 22:40:26, Dan Eble wrote:
> On 2018/04/21 18:40:18, Dan Eble wrote:
> 
> This will deserve some revision based on questions to be answered in the
review
> for issue 5310.

See updated and expanded changes in
https://codereview.appspot.com/561290043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b