Adding Debug/Release output modes, source maps and more externs files.

Adding Debug/Release output modes, source maps and more externs files.

Adding externs files (for chrome.* APIs and qunit).
Minor bug in run_*.
Adding a debug and release target (debug will have source mapping added).

[pajamallama, 2013-11-28 06:29:27]

https://codereview.appspot.com/34670043/diff/1/Makefile
File Makefile (left):

https://codereview.appspot.com/34670043/diff/1/Makefile#oldcode40
Makefile:40: app : $(BUILD_DIR) $(APP_SRCS)
Removed dependencies on source files: now 'make debug' etc will *always*
compile. If you have debug, release & test all depend on the original source
files then 'all: debug release test' will then never run the test compilation
for some reason (fixes anyone??).

https://codereview.appspot.com/34670043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34670043/diff/1/Makefile#newcode120
Makefile:120: # Download externs for the chrome.* APIs.
Originally I'd tried to do:

$(BUILD_DIR) : $(CLOSURE_COMPILER) $(CHROME_EXTERNS) $(QUNIT_EXTERNS)
    # download closure
    # download chrome externs
    # download qunit externs

But if 'build/' exists then it doesn't even look to see if the compiler exists
(for e.g.).. :(

https://codereview.appspot.com/34670043/diff/1/Makefile#newcode143
Makefile:143: run_debug :
Removed dependency of 'debug' so that run_* will launch without having to wait
for compilation. 

This is because the debug/release/test targets will always compile (see previous
note).

[pajamallama, 2013-11-28 06:31:39]

https://codereview.appspot.com/34670043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34670043/diff/1/Makefile#newcode151
Makefile:151: 
Do I need a .PHONY?

[Matt Giuca, 2013-11-29 01:00:31]

lgtm

https://codereview.appspot.com/34670043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34670043/diff/1/Makefile#newcode151
Makefile:151: 
Yeah I think so.

https://codereview.appspot.com/34670043/diff/80001/Makefile
File Makefile (right):

https://codereview.appspot.com/34670043/diff/80001/Makefile#newcode38
Makefile:38: --externs $(EXTERNS) --externs $(CHROME_EXTERNS) --externs
$(QUNIT_EXTERNS)
Did you mean to remove CURDIR?

https://codereview.appspot.com/34670043/diff/80001/Makefile#newcode48
Makefile:48: cp -r $(APPDIR)/* $(OUTDIR)/$(DEBUGDIR)
I think I would be happier with:

mkdir -p $(OUTDIR)
cp -r $(APPDIR) $(OUTDIR)/$(DEBUGDIR)

This would copy the whole $APPDIR directory, instead of merely copying the *
files inside it (which means, for example, you won't be ignoring dotfiles).

https://codereview.appspot.com/34670043/diff/80001/Makefile#newcode67
Makefile:67: cp -r $(APPDIR)/* $(OUTDIR)/$(RELEASEDIR)
If you take my advice above, please update this one too.

https://codereview.appspot.com/34670043/diff/80001/build/externs.js
File build/externs.js (right):

https://codereview.appspot.com/34670043/diff/80001/build/externs.js#newcode8
build/externs.js:8: 
Is this change related to the Make changes? Perhaps this could go in a separate
CL as well?

[calamity, 2013-11-29 01:47:26]

https://codereview.appspot.com/34670043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34670043/diff/1/Makefile#newcode151
Makefile:151: 
On 2013/11/28 06:31:39, pajamallama wrote:
> Do I need a .PHONY? 

No, the .PHONY was there so that changes to the .html files etc would be picked
up when make was run.

https://codereview.appspot.com/34670043/diff/60001/Makefile
File Makefile (right):

https://codereview.appspot.com/34670043/diff/60001/Makefile#newcode85
Makefile:85: test : setup
The test target is still broken. You'll need to declare
chrome.runtime.getPackageDirectoryEntry() in build/externs.js and change this so
that main.js isn't compiled (define a variable TEST_EXCLUDES and use make's
filter-out function).

[Matt Giuca, 2013-12-10 02:32:52]

Hey, can you close this CL? I think calamity has taken care of it now.