Simplified the Makefile and the targets.

Simplified the Makefile and the targets.

Removes the need to list every source file in the Makefile (it will instead use the contents of app/js/ and test/js).

Removes the OUT_* targets, now 'make' will copy app/* and test/* into out/.

Compiling now doesn't run gjslint. The lint target is for that purpose.

Removing all $@ and $< for readability.

[pajamallama, 2013-11-28 05:02:17]

https://codereview.appspot.com/34620043/diff/1/.gitignore
File .gitignore (right):

https://codereview.appspot.com/34620043/diff/1/.gitignore#newcode3
.gitignore:3: *.swp
ignore vim swp files

https://codereview.appspot.com/34620043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode9
Makefile:9: APP_DIR := app
Renaming *DIR to *_DIR for readability

https://codereview.appspot.com/34620043/diff/1/build/externs.js
File build/externs.js (left):

https://codereview.appspot.com/34620043/diff/1/build/externs.js#oldcode14
build/externs.js:14: log: function(s) {}
This gave a compile error.

[calamity, 2013-11-28 06:57:23]

Looking good. Hopefully we can get ToT into a fully working state soon.

https://codereview.appspot.com/34620043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode8
Makefile:8: CD := $(shell pwd)
Any reason not to use $(CURDIR)? Apparently it's a make built-in. Either way, I
think CD is a confusing name since it usually stand for change directory. Maybe
CWD?

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode69
Makefile:69: cp $(APP_DIR)/$(SRC_DIR)/* $(OUT_DIR)/$(TEST_DIR)/$(SRC_DIR)
Any reason to use a glob instead of $(TEST_FILES)? Likewise with everywhere else
that uses globs instead of the equivalent variable.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode76
Makefile:76: --js_output_file $(PROJECT).js \
Maybe $(PROJECT)_test.js?

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode85
Makefile:85: mkdir $(BUILD_DIR)
This needs to stay as mkdir -p. It currently errors because "build" has already
been created

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode93
Makefile:93: gjslint $(ALL_SRCS) $(EXTERNS)
Why remove the $(LINT) variable?

[pajamallama, 2013-11-28 07:06:05]

https://codereview.appspot.com/34620043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode8
Makefile:8: CD := $(shell pwd)
On 2013/11/28 06:57:24, calamity wrote:
> Any reason not to use $(CURDIR)? Apparently it's a make built-in. Either way,
I
> think CD is a confusing name since it usually stand for change directory.
Maybe
> CWD?

It's a Make builtin?? I didn't know they existed. I'll revert to that.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode69
Makefile:69: cp $(APP_DIR)/$(SRC_DIR)/* $(OUT_DIR)/$(TEST_DIR)/$(SRC_DIR)
On 2013/11/28 06:57:24, calamity wrote:
> Any reason to use a glob instead of $(TEST_FILES)? Likewise with everywhere
else
> that uses globs instead of the equivalent variable.

That way subdirectories are preserved, otherwise app/js/a.js will end up in
out/debug/a.js (instead of out/debug/js/a.js).

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode76
Makefile:76: --js_output_file $(PROJECT).js \
On 2013/11/28 06:57:24, calamity wrote:
> Maybe $(PROJECT)_test.js?

Hmm kk.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode85
Makefile:85: mkdir $(BUILD_DIR)
On 2013/11/28 06:57:24, calamity wrote:
> This needs to stay as mkdir -p. It currently errors because "build" has
already
> been created

Yeah, this was an error (introduced by severe git-ing), it is fixed in the next
cl.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode93
Makefile:93: gjslint $(ALL_SRCS) $(EXTERNS)
On 2013/11/28 06:57:24, calamity wrote:
> Why remove the $(LINT) variable?

No need to keep it, in this version lint is only called in one location.

[calamity, 2013-11-28 23:59:50]

lgtm with nits.

Please update the issue comment as well as some things no longer apply.

https://codereview.appspot.com/34620043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode69
Makefile:69: cp $(APP_DIR)/$(SRC_DIR)/* $(OUT_DIR)/$(TEST_DIR)/$(SRC_DIR)
On 2013/11/28 07:06:05, pajamallama wrote:
> On 2013/11/28 06:57:24, calamity wrote:
> > Any reason to use a glob instead of $(TEST_FILES)? Likewise with everywhere
> else
> > that uses globs instead of the equivalent variable.
> 
> That way subdirectories are preserved, otherwise app/js/a.js will end up in
> out/debug/a.js (instead of out/debug/js/a.js).

Replacing $(APP_DIR)/$(SRC_DIR)/* with $(APP_SRCS) shouldn't affect the output
directory structure? Using a variable would be more flexible so I'd prefer that
if possible.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode85
Makefile:85: mkdir $(BUILD_DIR)
On 2013/11/28 07:06:05, pajamallama wrote:
> On 2013/11/28 06:57:24, calamity wrote:
> > This needs to stay as mkdir -p. It currently errors because "build" has
> already
> > been created
> 
> Yeah, this was an error (introduced by severe git-ing), it is fixed in the
next
> cl.

May as well add the -p in this patchset.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode93
Makefile:93: gjslint $(ALL_SRCS) $(EXTERNS)
On 2013/11/28 07:06:05, pajamallama wrote:
> On 2013/11/28 06:57:24, calamity wrote:
> > Why remove the $(LINT) variable?
> 
> No need to keep it, in this version lint is only called in one location.

Fair enough.

[pajamallama, 2013-11-29 00:24:55]

https://codereview.appspot.com/34620043/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode69
Makefile:69: cp $(APP_DIR)/$(SRC_DIR)/* $(OUT_DIR)/$(TEST_DIR)/$(SRC_DIR)
On 2013/11/28 23:59:50, calamity wrote:
> On 2013/11/28 07:06:05, pajamallama wrote:
> > On 2013/11/28 06:57:24, calamity wrote:
> > > Any reason to use a glob instead of $(TEST_FILES)? Likewise with
everywhere
> > else
> > > that uses globs instead of the equivalent variable.
> > 
> > That way subdirectories are preserved, otherwise app/js/a.js will end up in
> > out/debug/a.js (instead of out/debug/js/a.js).
> 
> Replacing $(APP_DIR)/$(SRC_DIR)/* with $(APP_SRCS) shouldn't affect the output
> directory structure? Using a variable would be more flexible so I'd prefer
that
> if possible.

Done.

https://codereview.appspot.com/34620043/diff/1/Makefile#newcode85
Makefile:85: mkdir $(BUILD_DIR)
On 2013/11/28 23:59:50, calamity wrote:
> On 2013/11/28 07:06:05, pajamallama wrote:
> > On 2013/11/28 06:57:24, calamity wrote:
> > > This needs to stay as mkdir -p. It currently errors because "build" has
> > already
> > > been created
> > 
> > Yeah, this was an error (introduced by severe git-ing), it is fixed in the
> next
> > cl.
> 
> May as well add the -p in this patchset.

Done.