Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(981)

Issue 346130043: Issue 5387: align brackets only to visible Stems

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by Malte Meyn
Modified:
1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5387: align brackets only to visible Stems TupletBrackets and LigatureBrackets now don’t take into account stems of rests, whole and longer notes and stems that are omitted. Contains regtests.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
A input/regression/ligature-bracket-X-positions.ly View 1 chunk +17 lines, -0 lines 0 comments Download
A input/regression/tuplet-bracket-X-positions.ly View 1 chunk +18 lines, -0 lines 0 comments Download
M lily/tuplet-bracket.cc View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 1
Malte Meyn
1 month ago (2018-07-19 14:58:47 UTC) #1
This doesn’t follow Gould (see sf tracker for her suggestion) but modifies
LilyPond’s current behaviour: If there is a stem on the same side/direction,
align to that. Else align to the rest/note head.

https://codereview.appspot.com/346130043/diff/1/lily/tuplet-bracket.cc
File lily/tuplet-bracket.cc (right):

https://codereview.appspot.com/346130043/diff/1/lily/tuplet-bracket.cc#newcode75
lily/tuplet-bracket.cc:75: && unsmob<Stencil> (s->get_property ("stencil")))
I tried to put this check (does the Stem have a stencil?) into
Stem::is_invisible but that seems to be the wrong thing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b