Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 346050043: Issue 5332: \denies C should cancel \defaultchild C (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by Dan Eble
Modified:
5 years, 9 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5332/ This also makes context modifications consistent with context definitions in using the last \defaultchild command rather than the first. It pains me to make hairy code hairier, but I thought it would be better to make these minimal functional changes first and refactor later.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -10 lines) Patch
A input/regression/context-defaultchild-def.ly View 1 chunk +32 lines, -0 lines 0 comments Download
A input/regression/context-defaultchild-mod.ly View 1 chunk +29 lines, -0 lines 0 comments Download
A input/regression/context-denies-defaultchild-def.ly View 1 chunk +37 lines, -0 lines 0 comments Download
A input/regression/context-denies-defaultchild-mod.ly View 1 chunk +38 lines, -0 lines 0 comments Download
M lily/context.cc View 1 chunk +10 lines, -5 lines 1 comment Download
M lily/context-def.cc View 2 chunks +13 lines, -5 lines 2 comments Download

Messages

Total messages: 1
Dan Eble
5 years, 10 months ago (2018-05-29 01:57:06 UTC) #1
https://codereview.appspot.com/346050043/diff/1/lily/context-def.cc
File lily/context-def.cc (right):

https://codereview.appspot.com/346050043/diff/1/lily/context-def.cc#newcode142
lily/context-def.cc:142: else if (scm_is_eq (tag, ly_symbol2scm ("denies")))
This makes \denies cancel \defaultchild in context definitions.

https://codereview.appspot.com/346050043/diff/1/lily/context-def.cc#newcode197
lily/context-def.cc:197: if (scm_is_eq (tag, ly_symbol2scm ("denies")))
This makes \denies cancel \defaultchild in context modifications.

https://codereview.appspot.com/346050043/diff/1/lily/context.cc
File lily/context.cc (right):

https://codereview.appspot.com/346050043/diff/1/lily/context.cc#newcode338
lily/context.cc:338: {
This is why \denies and \defaultchild did not work inside \with.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b