Issue 34580044: code review 34580044: cmd/5c, cmd/6c, cmd/8c: use liblink

Issue 34580044: code review 34580044: cmd/5c, cmd/6c, cmd/8c: use liblink (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rsc

Modified:
11 years, 7 months ago

Reviewers:
iant

CC:
iant, golang-dev

Visibility:
Public.

Description

cmd/5c, cmd/6c, cmd/8c: use liblink Preparation for golang.org/s/go13linker work. This CL does not build by itself. It depends on 35740044 and 35790044 and will be submitted at the same time.

Patch Set 2 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Patch Set 5 : diff -r 7326da92ff4d https://code.google.com/p/go/ #

Total comments: 5

Patch Set 6 : diff -r d245b1701154 https://code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -1249 lines)			Patch
M	src/cmd/5c/gc.h	View	1	10 chunks	+19 lines, -47 lines	0 comments	Download
M	src/cmd/5c/list.c	View	1	8 chunks	+17 lines, -17 lines	0 comments	Download
M	src/cmd/5c/peep.c	View	1 2 3 4 5	21 chunks	+22 lines, -22 lines	0 comments	Download
M	src/cmd/5c/reg.c	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/5c/swt.c	View	1	4 chunks	+4 lines, -280 lines	0 comments	Download
M	src/cmd/5c/txt.c	View	1 2	11 chunks	+17 lines, -16 lines	0 comments	Download
M	src/cmd/6c/gc.h	View	1	10 chunks	+16 lines, -40 lines	0 comments	Download
M	src/cmd/6c/list.c	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/cmd/6c/peep.c	View	1	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/6c/reg.c	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	src/cmd/6c/swt.c	View	1	4 chunks	+5 lines, -271 lines	0 comments	Download
M	src/cmd/6c/txt.c	View	1 2	9 chunks	+16 lines, -15 lines	0 comments	Download
M	src/cmd/8c/gc.h	View	1	10 chunks	+16 lines, -40 lines	0 comments	Download
M	src/cmd/8c/list.c	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/cmd/8c/peep.c	View	1	8 chunks	+8 lines, -8 lines	0 comments	Download
M	src/cmd/8c/reg.c	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	src/cmd/8c/swt.c	View	1	4 chunks	+5 lines, -267 lines	0 comments	Download
M	src/cmd/8c/txt.c	View	1 2	8 chunks	+15 lines, -14 lines	0 comments	Download
M	src/cmd/cc/cc.h	View	1 2 3	10 chunks	+5 lines, -14 lines	0 comments	Download
M	src/cmd/cc/lex.c	View	1 2	5 chunks	+4 lines, -73 lines	0 comments	Download
M	src/cmd/cc/macbody	View	1	4 chunks	+2 lines, -54 lines	0 comments	Download
M	src/cmd/cc/pswt.c	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
M	src/cmd/cc/sub.c	View	1 2 3	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 7 months ago (2013-12-04 19:22:11 UTC) #1

iant

LGTM https://codereview.appspot.com/34580044/diff/80001/src/cmd/5c/peep.c File src/cmd/5c/peep.c (right): https://codereview.appspot.com/34580044/diff/80001/src/cmd/5c/peep.c#newcode1109 src/cmd/5c/peep.c:1109: if((uchar)v->reg == (uchar)REGARG) Can remove cast on both ...

11 years, 7 months ago (2013-12-05 22:47:21 UTC) #2

rsc

Done. https://codereview.appspot.com/34580044/diff/80001/src/cmd/5c/peep.c File src/cmd/5c/peep.c (right): https://codereview.appspot.com/34580044/diff/80001/src/cmd/5c/peep.c#newcode1109 src/cmd/5c/peep.c:1109: if((uchar)v->reg == (uchar)REGARG) On 2013/12/05 22:47:21, iant wrote: ...

11 years, 7 months ago (2013-12-09 03:34:28 UTC) #3

rsc

https://codereview.appspot.com/34580044/diff/80001/src/cmd/5c/peep.c File src/cmd/5c/peep.c (right): https://codereview.appspot.com/34580044/diff/80001/src/cmd/5c/peep.c#newcode1109 src/cmd/5c/peep.c:1109: if((uchar)v->reg == (uchar)REGARG) On 2013/12/09 03:34:29, rsc wrote: > ...

11 years, 7 months ago (2013-12-09 03:36:03 UTC) #4

rsc

11 years, 7 months ago (2013-12-09 03:51:35 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=a58a6f7b6d4c ***

cmd/5c, cmd/6c, cmd/8c: use liblink

Preparation for golang.org/s/go13linker work.

This CL does not build by itself. It depends on 35740044
and 35790044 and will be submitted at the same time.

R=iant
CC=golang-dev
https://codereview.appspot.com/34580044

Expand All Messages | Collapse All Messages