Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(371)

Issue 34520043: Added scroll header collapse to charm details (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by huwshimi
Modified:
10 years, 4 months ago
Reviewers:
jeff.pihach, mp+196994
Visibility:
Public.

Description

Added scroll header collapse to charm details On the sidebar details panel for charms and bundles I've added the header collapse and animation when you scroll the content. https://code.launchpad.net/~huwshimi/juju-gui/panel-sticky-header/+merge/196994 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added scroll header collapse to charm details #

Patch Set 3 : Added scroll header collapse to charm details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -23 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/views/bundle.js View 1 chunk +4 lines, -0 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 chunk +2 lines, -10 lines 0 comments Download
M app/subapps/browser/views/entity-base.js View 1 2 chunks +29 lines, -1 line 0 comments Download
M lib/views/browser/charm-full.less View 5 chunks +23 lines, -9 lines 0 comments Download
M lib/views/browser/main.less View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/views/browser/tabview.less View 3 chunks +19 lines, -1 line 0 comments Download
M lib/views/content-panel.less View 1 3 chunks +25 lines, -2 lines 0 comments Download
M lib/views/juju-inspector.less View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
huwshimi
Please take a look.
10 years, 4 months ago (2013-11-27 23:33:12 UTC) #1
jeff.pihach
Great functionality LGTM with trivial QA OKish When scrolling down the header animates smaller (very ...
10 years, 4 months ago (2013-11-27 23:44:36 UTC) #2
huwshimi
Please take a look.
10 years, 4 months ago (2013-11-28 03:48:24 UTC) #3
huwshimi
On 2013/11/27 23:44:36, jeff.pihach wrote: > Great functionality LGTM with trivial > > QA OKish ...
10 years, 4 months ago (2013-11-28 03:56:25 UTC) #4
huwshimi
10 years, 4 months ago (2013-11-28 04:47:56 UTC) #5
*** Submitted:

Added scroll header collapse to charm details

On the sidebar details panel for charms and bundles I've added the header
collapse and animation when you scroll the content.

R=jeff.pihach
CC=
https://codereview.appspot.com/34520043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b