Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6882)

Issue 34420043: Add autologin support for quickstart

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by gary.poster
Modified:
10 years, 5 months ago
Reviewers:
mp+196982, matthew.scott
Visibility:
Public.

Description

Add autologin support for quickstart To qa, please do the following. Story 1: quickstart works without autologin support for charm. Simply run `.venv/bin/python juju-quickstart`. This will bring up the existing charm, which does not have support for autologin. It should work fine, with password. Story 2: quickstart works with autologin when available. Run `.venv/bin/python juju-quickstart --gui-charm-url cs:~juju-gui/precise/juju-gui-134`. This should bring up the GUI with autologin. Thank you! https://code.launchpad.net/~gary/juju-quickstart/authtoken/+merge/196982 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add autologin support for quickstart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M quickstart/app.py View 3 chunks +17 lines, -2 lines 0 comments Download
M quickstart/juju.py View 1 chunk +17 lines, -0 lines 0 comments Download
M quickstart/manage.py View 2 chunks +6 lines, -3 lines 0 comments Download
M quickstart/tests/test_app.py View 2 chunks +46 lines, -18 lines 0 comments Download
M quickstart/tests/test_juju.py View 1 chunk +6 lines, -0 lines 0 comments Download
M quickstart/tests/test_manage.py View 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
10 years, 5 months ago (2013-11-27 21:17:31 UTC) #1
matthew.scott
LGTM, QA okay!
10 years, 5 months ago (2013-11-27 23:47:37 UTC) #2
gary.poster
*** Submitted: Add autologin support for quickstart To qa, please do the following. Story 1: ...
10 years, 5 months ago (2013-11-27 23:58:13 UTC) #3
gary.poster
10 years, 5 months ago (2013-11-28 00:14:36 UTC) #4
Thank you for the review and QA, Matt.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b