Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 344120043: Issue 5463: Fix dblatex uses xetex backend

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by trueroad
Modified:
2 months, 3 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5463: Fix dblatex uses xetex backend The configure script set PDFLATEX=/path/to/xelatex-with-options.sh when the system has xelatex. However, makefile for dblatex document build was checking PDFLATEX=xelatex to decide whether to use xetex backend or not. Therefore, even if the system has xelatex, dblatex did not use xetex backend. This commit makes dblatex use xetex backend when the system has xelatex.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix makefile syntax #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M make/lilypond-book-vars.make View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
lemzwerg
https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make File make/lilypond-book-vars.make (right): https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make#newcode43 make/lilypond-book-vars.make:43: ifneq (,($findstring xelatex,($notdir $(PDFLATEX)))) Shouldn't this be rather ifneq ...
3 months ago (2019-01-19 12:00:17 UTC) #1
trueroad
Fix makefile syntax
3 months ago (2019-01-19 12:59:05 UTC) #2
trueroad
Thank you for your reviewing. https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make File make/lilypond-book-vars.make (right): https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make#newcode43 make/lilypond-book-vars.make:43: ifneq (,($findstring xelatex,($notdir $(PDFLATEX)))) ...
3 months ago (2019-01-19 13:07:00 UTC) #3
trueroad
2 months, 3 weeks ago (2019-01-26 13:47:34 UTC) #4
I've pushed to the staging.

Issue 5463: Fix dblatex uses xetex backend
commit 002382ca44a8a72260829d1e0d9a73cb93809d08
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b