Code review - Issue 344120043: Issue 5463: Fix dblatex uses xetex backendhttps://codereview.appspot.com/2019-01-26T13:47:34+00:00rietveld
Message from unknown
2019-01-19T07:05:57+00:00trueroadurn:md5:238faf4171b5dd2437a622a92dc4bf2c
Message from lemzwerg@googlemail.com
2019-01-19T12:00:17+00:00lemzwergurn:md5:2937579bd945ebc6b5476d6b7d6e5baf
https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make
File make/lilypond-book-vars.make (right):
https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make#newcode43
make/lilypond-book-vars.make:43: ifneq (,($findstring xelatex,($notdir $(PDFLATEX))))
Shouldn't this be rather
ifneq (,$(findstring xelatex,$(notdir $(PDFLATEX))))
? According to the `make.info`, functions have the syntax `$(foo ...)`.
Message from unknown
2019-01-19T12:59:04+00:00trueroadurn:md5:98fbdb0ff2d04247b62caeab481155a6
Message from trueroad@gmail.com
2019-01-19T12:59:05+00:00trueroadurn:md5:03275e14890eb32d450a6d89885680b4
Fix makefile syntax
Message from trueroad@gmail.com
2019-01-19T13:07:00+00:00trueroadurn:md5:eec4619f969a2232fdad076ef70d569c
Thank you for your reviewing.
https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make
File make/lilypond-book-vars.make (right):
https://codereview.appspot.com/344120043/diff/1/make/lilypond-book-vars.make#newcode43
make/lilypond-book-vars.make:43: ifneq (,($findstring xelatex,($notdir $(PDFLATEX))))
On 2019/01/19 12:00:17, lemzwerg wrote:
> Shouldn't this be rather
>
> ifneq (,$(findstring xelatex,$(notdir $(PDFLATEX))))
>
> ? According to the `make.info`, functions have the syntax `$(foo ...)`.
Done.
Message from trueroad@gmail.com
2019-01-26T13:47:34+00:00trueroadurn:md5:250ce00d5b9f5c5f41d839e9f243023a
I've pushed to the staging.
Issue 5463: Fix dblatex uses xetex backend
commit 002382ca44a8a72260829d1e0d9a73cb93809d08