Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1382)

Issue 343970043: Allow use of Identity-H CMap and CID versions of Emmentaler

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by knupero
Modified:
1 year ago
Reviewers:
trueroad, carl.d.sorensen, dak, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow use of Identity-H CMap and CID versions of Emmentaler When -O TeX or -O TeX-GS is given, lilypond generates postscript code that instructs ghostscript to use the Identity-H CMap and CID versions of the emmentaler fonts. Used e.g. by 'make doc'. Without '-O TeX' or '-O TeX-GS' we still use the traditional postscript code. Documentation is missing. Only a proof of concept, definitely not ready for release. Tested only with current lilypond and ghostscript master. Signed-off-by: Knut Petersen <knut_petersen@t-online.de>

Patch Set 1 #

Total comments: 11

Patch Set 2 : Patchset #2 (support case insensitive filename namespaces, etc) #

Patch Set 3 : Also use CMap Identity-H for TeX Gyre Schola family, some fixes and enhancements. #

Total comments: 4

Patch Set 4 : cleanup / change command line / add otfinfo check / etc / change default ps output mode #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -1915 lines) Patch
M GNUmakefile.in View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M configure.ac View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M lily/main.cc View 1 2 3 2 chunks +12 lines, -9 lines 0 comments Download
M make/lilypond-book-rules.make View 2 chunks +2 lines, -2 lines 0 comments Download
M mf/GNUmakefile View 1 2 3 9 chunks +90 lines, -4 lines 1 comment Download
A mf/Identity-H View 1 1 chunk +339 lines, -0 lines 0 comments Download
M mf/emmentaler-brace.pe.in View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A mf/texgyreschola.pe.in View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M ps/GNUmakefile View 1 chunk +12 lines, -1 line 0 comments Download
A ps/cidres.in View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M ps/encodingdefs.ps View 1 2 1 chunk +46 lines, -1845 lines 0 comments Download
M ps/music-drawing-routines.ps View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 1 2 3 2 chunks +15 lines, -22 lines 0 comments Download
M scm/lily.scm View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M scm/output-ps.scm View 1 2 3 2 chunks +58 lines, -27 lines 0 comments Download
M scripts/build/gen-emmentaler-scripts.py View 1 1 chunk +6 lines, -0 lines 0 comments Download
M stepmake/stepmake/texinfo-rules.make View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15
knupero
Please review.
1 year ago (2018-05-26 13:20:46 UTC) #1
Carl
The patch looks well put together. However, I believe that the case problem with MacOS ...
1 year ago (2018-05-26 15:17:09 UTC) #2
lemzwerg
LGTM, but I share Carl's concerns, in particular the issue with font names that only ...
1 year ago (2018-05-26 16:25:25 UTC) #3
dak
lemzwerg@googlemail.com writes: > LGTM, but I share Carl's concerns, in particular the issue with font ...
1 year ago (2018-05-26 16:45:09 UTC) #4
knupero
> However, I believe that the case problem with MacOS needs to be fixed. I ...
1 year ago (2018-05-26 22:24:49 UTC) #5
knupero
https://codereview.appspot.com/343970043/diff/1/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/343970043/diff/1/mf/GNUmakefile#newcode145 mf/GNUmakefile:145: cd $(outdir) && mv $(notdir $@).otf $(notdir $@) On ...
1 year ago (2018-05-26 22:48:39 UTC) #6
trueroad
Great! But, I failed to build in my Cygwin (case insensitive) environment. >> I think ...
1 year ago (2018-05-27 02:57:22 UTC) #7
knupero
Patchset #2 (support case insensitive filename namespaces, etc)
1 year ago (2018-05-28 07:34:39 UTC) #8
knupero
Also use CMap Identity-H for TeX Gyre Schola family, some fixes and enhancements.
1 year ago (2018-05-29 22:44:44 UTC) #9
knupero
On 2018/05/29 22:44:44, knupero wrote: > Also use CMap Identity-H for TeX Gyre Schola family, ...
1 year ago (2018-05-29 22:49:50 UTC) #10
lemzwerg
Nice! https://codereview.appspot.com/343970043/diff/40001/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/343970043/diff/40001/mf/GNUmakefile#newcode183 mf/GNUmakefile:183: echo XXXX $(TEXGYRE_DIR)/texgyreschola-regular.otf YYY This looks like a ...
1 year ago (2018-05-30 04:31:55 UTC) #11
knupero
cleanup / change command line / add otfinfo check / etc / change default ps ...
1 year ago (2018-05-30 11:50:19 UTC) #12
knupero
Changes: Command line: "-O size" is gone "-O legacy" is added, uses our old non-encodings ...
1 year ago (2018-05-30 12:23:58 UTC) #13
knupero
Answers to comments. https://codereview.appspot.com/343970043/diff/1/mf/GNUmakefile File mf/GNUmakefile (right): https://codereview.appspot.com/343970043/diff/1/mf/GNUmakefile#newcode145 mf/GNUmakefile:145: cd $(outdir) && mv $(notdir $@).otf ...
1 year ago (2018-05-30 12:32:14 UTC) #14
trueroad
1 year ago (2018-06-02 02:48:26 UTC) #15
https://codereview.appspot.com/343970043/diff/60001/mf/GNUmakefile
File mf/GNUmakefile (right):

https://codereview.appspot.com/343970043/diff/60001/mf/GNUmakefile#newcode165
mf/GNUmakefile:165: cd $(outdir) && mv $(notdir $<) $(notdir $@)
Is it necessary to change the file name?
I think that the extension `.otf' is more suitable than the extension `.cid'
since `emmentaler-*-cid.otf' is in Open Type Font format.

If I understand correctly, a file with extension `.cid' means old CID format
instead of OTF format.
The OTF format can contain a CID keyed fonts as well as non-CID keyed fonts.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b