Issue 343790043: [dfvfs] Changed recursive hasher to use SHA-256 and print partitions #291

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 343790043: [dfvfs] Changed recursive hasher to use SHA-256 and print partitions #291 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years ago by Joachim Metz

Modified:
6 years ago

Reviewers:
romaing

CC:
kiddi, log2timeline-dev_googlegroups.com, onager

Visibility:
Public.

More Reviews

Description

[dfvfs] Changed recursive hasher to use SHA-256 and print partitions #291

Patch Set 2 : Changes after review #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -18 lines)			Patch
	M	examples/recursive_hasher.py	View	1	5 chunks	+33 lines, -15 lines	0 comments	Download
	M	test_data/end_to_end/image.qcow2.hashes	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

romaing

https://codereview.appspot.com/343790043/diff/1/examples/recursive_hasher.py File examples/recursive_hasher.py (right): https://codereview.appspot.com/343790043/diff/1/examples/recursive_hasher.py#newcode484 examples/recursive_hasher.py:484: def _FormatPathSpecAsHumanReadablePath(self, path_spec): I fail to see where this ...

6 years ago (2018-04-12 15:06:18 UTC) #2

Joachim Metz

6 years ago (2018-04-12 18:23:29 UTC) #3

Joachim Metz

6 years ago (2018-04-14 06:43:40 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close rhasher

Expand All Messages | Collapse All Messages