Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 3434045: Bypass the -pthread -shared check for unknown platforms

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Jisi Liu
Modified:
13 years, 4 months ago
Reviewers:
kenton
CC:
kenton+urgent_google.com
Base URL:
http://protobuf.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M m4/acx_pthread.m4 View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 2
Jisi Liu
Hmm, so I was testing protobuf on Mac OS.. It turns out the -phthread and ...
13 years, 4 months ago (2010-12-08 17:45:32 UTC) #1
kenton
13 years, 4 months ago (2010-12-09 01:10:21 UTC) #2
http://codereview.appspot.com/3434045/diff/1/m4/acx_pthread.m4
File m4/acx_pthread.m4 (right):

http://codereview.appspot.com/3434045/diff/1/m4/acx_pthread.m4#newcode284
m4/acx_pthread.m4:284: AC_MSG_CHECKING([whether -pthread is sufficient with
-shared])
I think what we want to do is figure out why this check fails on OSX, and fix
it.  Can you find it in config.log?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b