Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(317)

Issue 343260043: [plaso] Updated Windows release build script to include YAML files #1917 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by Joachim Metz
Modified:
4 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, romaing
Visibility:
Public.

Description

[plaso] Updated Windows release build script to include YAML files #1917

Patch Set 1 : Updated Windows release build script to include YAML files #1917 #

Total comments: 2

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M config/windows/make_check.bat View 1 chunk +2 lines, -0 lines 0 comments Download
M config/windows/make_release.ps1 View 1 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
4 months, 1 week ago (2018-06-10 06:13:12 UTC) #1
Joachim Metz
Code updated.
4 months, 1 week ago (2018-06-10 06:18:42 UTC) #2
onager
https://codereview.appspot.com/343260043/diff/20001/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/343260043/diff/20001/config/windows/make_release.ps1#newcode195 config/windows/make_release.ps1:195: git.exe clone https://github.com/ForensicArtifacts/dfvfs.git dist\dfvfs Please fix the URLs here, ...
4 months ago (2018-06-11 16:50:04 UTC) #3
Joachim Metz
https://codereview.appspot.com/343260043/diff/20001/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/343260043/diff/20001/config/windows/make_release.ps1#newcode195 config/windows/make_release.ps1:195: git.exe clone https://github.com/ForensicArtifacts/dfvfs.git dist\dfvfs On 2018/06/11 16:50:04, onager wrote: ...
4 months ago (2018-06-12 04:37:28 UTC) #4
Joachim Metz
Code updated.
4 months ago (2018-06-12 04:42:11 UTC) #5
onager
LGTM
4 months ago (2018-06-13 13:57:34 UTC) #6
Joachim Metz
4 months ago (2018-06-13 16:39:30 UTC) #7
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close fix1917
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b