Issue 343260043: [plaso] Updated Windows release build script to include YAML files #1917

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 343260043: [plaso] Updated Windows release build script to include YAML files #1917 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 11 months ago by Joachim Metz

Modified:
5 years, 11 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing

Visibility:
Public.

More Reviews

Description

[plaso] Updated Windows release build script to include YAML files #1917

Patch Set 1 : Updated Windows release build script to include YAML files #1917 #

Total comments: 2

Patch Set 2 : Changes after review #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	config/windows/make_check.bat	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	config/windows/make_release.ps1	View	1	1 chunk	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/343260043/diff/20001/config/windows/make_release.ps1 File config/windows/make_release.ps1 (right): https://codereview.appspot.com/343260043/diff/20001/config/windows/make_release.ps1#newcode195 config/windows/make_release.ps1:195: git.exe clone https://github.com/ForensicArtifacts/dfvfs.git dist\dfvfs Please fix the URLs here, ...

5 years, 11 months ago (2018-06-11 16:50:04 UTC) #3

Joachim Metz

5 years, 11 months ago (2018-06-12 04:37:28 UTC) #4

Joachim Metz

5 years, 11 months ago (2018-06-13 16:39:30 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close fix1917

Expand All Messages | Collapse All Messages