Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(414)

Issue 343060043: Clarify notation for slurs and beams

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Carl
Modified:
1 year, 2 months ago
Reviewers:
Be-3, dak, c_sorensen, Trevor Daniels, t.daniels, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Clarify notation for slurs and beams Note that the opening code for slurs and beams comes after the first note of the slur or beam. Also, add a section about notes containing pitches, durations, and post-events.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Respond to Trevor and Torsten #

Total comments: 3

Patch Set 3 : Adjust titles and menus #

Total comments: 8

Patch Set 4 : Adjust description of post-events #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -6 lines) Patch
M Documentation/learning/common-notation.itely View 1 2 6 chunks +11 lines, -5 lines 0 comments Download
M Documentation/learning/fundamental.itely View 1 2 3 2 chunks +41 lines, -0 lines 0 comments Download
M Documentation/notation/expressive.itely View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20
Be-3
Hi Carl, Concise, comprehensible, - LGTM! Perhaps it should be explicitly pointed out that the ...
1 year, 2 months ago (2018-04-30 11:37:09 UTC) #1
Trevor Daniels
Hi Carl LGTM, with a couple of minor comments. Trevor https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely#newcode488 ...
1 year, 2 months ago (2018-04-30 12:08:20 UTC) #2
Carl
On 2018/04/30 11:37:09, Be-3 wrote: > Hi Carl, > > Concise, comprehensible, - LGTM! > ...
1 year, 2 months ago (2018-04-30 14:56:48 UTC) #3
Carl
On 2018/04/30 12:08:20, Trevor Daniels wrote: > > https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely#newcode488 > Documentation/learning/fundamental.itely:488: @end lilypond > I'd ...
1 year, 2 months ago (2018-04-30 15:03:35 UTC) #4
Carl
Respond to Trevor and Torsten
1 year, 2 months ago (2018-04-30 15:28:25 UTC) #5
Trevor Daniels
Hi Carl Another minor nit! Otherwise looks fine. Trevor https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely#newcode495 Documentation/learning/fundamental.itely:495: ...
1 year, 2 months ago (2018-04-30 15:47:26 UTC) #6
Carl
Thanks for the feedback, Trevor. https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely#newcode495 Documentation/learning/fundamental.itely:495: @rlearning{Adding text}. On 2018/04/30 ...
1 year, 2 months ago (2018-04-30 15:51:16 UTC) #7
Trevor Daniels
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely#newcode495 Documentation/learning/fundamental.itely:495: @rlearning{Adding text}. On 2018/04/30 15:51:16, Carl wrote: > On ...
1 year, 2 months ago (2018-04-30 17:04:02 UTC) #8
c_sorensen
On 4/30/18, 11:04 AM, "lilypond-devel on behalf of tdanielsmusic@googlemail.com" <lilypond-devel-bounces+c_sorensen=byu.edu@gnu.org on behalf of tdanielsmusic@googlemail.com> wrote: ...
1 year, 2 months ago (2018-04-30 17:16:13 UTC) #9
t.daniels_treda.co.uk
Carl, you wrote 30/04/2018 18:16:05 > >On 4/30/18, 11:04 AM, "lilypond-devel on behalf of >tdanielsmusic@googlemail.com" ...
1 year, 2 months ago (2018-04-30 17:29:13 UTC) #10
Carl
Adjust titles and menus
1 year, 2 months ago (2018-04-30 19:18:42 UTC) #11
thomasmorley651
Hi Carl, many thanks for your work. Some remarks: https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely#newcode465 Documentation/learning/fundamental.itely:465: ...
1 year, 2 months ago (2018-04-30 21:49:37 UTC) #12
Carl
Harm, Thanks for the input. I'm not sure I agree with you on all this, ...
1 year, 2 months ago (2018-04-30 22:19:12 UTC) #13
thomasmorley651
On 2018/04/30 22:19:12, Carl wrote: > https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely > File Documentation/learning/fundamental.itely (right): > > https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely#newcode465 > ...
1 year, 2 months ago (2018-04-30 22:55:35 UTC) #14
thomasmorley651
On 2018/04/30 22:55:35, thomasmorley651 wrote: > On 2018/04/30 22:19:12, Carl wrote: > > I don't ...
1 year, 2 months ago (2018-04-30 23:47:56 UTC) #15
Carl
According to parser.yy: In line 3259, a post_event is either: 1) post_event_nofinger, or 2) '-' ...
1 year, 2 months ago (2018-05-01 02:47:20 UTC) #16
dak
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely#newcode465 Documentation/learning/fundamental.itely:465: optionally followed by one or more post-events. Post-events add ...
1 year, 2 months ago (2018-05-01 03:26:24 UTC) #17
thomasmorley651
On 2018/05/01 02:47:20, Carl wrote: > According to parser.yy: > > In line 3259, a ...
1 year, 2 months ago (2018-05-01 20:14:34 UTC) #18
dak
On 2018/05/01 20:14:34, thomasmorley651 wrote: > in the light of your findings and David's reply ...
1 year, 2 months ago (2018-05-01 20:31:36 UTC) #19
Carl
1 year, 2 months ago (2018-05-02 23:13:54 UTC) #20
Adjust description of post-events
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b