Issue 342800043: [dfdatetime] Made precision a read-only property

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 342800043: [dfdatetime] Made precision a read-only property (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 1 month ago by Joachim Metz

Modified:
6 years, 1 month ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

[dfdatetime] Made precision a read-only property Depends on: https://codereview.appspot.com/335700043/

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -72 lines)			Patch
M	dfdatetime/cocoa_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/delphi_date_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/fake_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/fat_date_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/filetime.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/hfs_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/interface.py	View	1	5 chunks	+15 lines, -8 lines	0 comments	Download
M	dfdatetime/java_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/ole_automation_date.py	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	dfdatetime/posix_time.py	View	1 2	6 chunks	+8 lines, -12 lines	0 comments	Download
M	dfdatetime/rfc2579_date_time.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dfdatetime/semantic_time.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	dfdatetime/systemtime.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	dfdatetime/time_elements.py	View	1 2	9 chunks	+12 lines, -17 lines	0 comments	Download
M	dfdatetime/uuid_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	dfdatetime/webkit_time.py	View		2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 6

Joachim Metz

6 years, 1 month ago (2018-03-24 13:06:16 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close precision