Issue 342790043: Adding signed integer arithmetic logic to C++ number formatting/parsing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 342790043: Adding signed integer arithmetic logic to C++ number formatting/parsing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 1 month ago by sffc

Modified:
6 years ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat4/icu4c/source/

Visibility:
Public.

Adding signed integer arithmetic logic to C++ number formatting/parsing

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -9 lines)			Patch
M	common/putil.cpp	View	1 chunk	+24 lines, -0 lines	2 comments	Download
M	common/putilimp.h	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	i18n/number_decimalquantity.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	i18n/number_decimalquantity.cpp	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	i18n/numparse_decimal.cpp	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	test/cintltst/putiltst.c	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 4

sffc

Again, optional review. Adding uprv_mul32_overflow and uprv_add32_overflow.

6 years, 1 month ago (2018-03-21 23:59:48 UTC) #1

andy.heninger

Other than the stray #include, LGTM. Which ICU ticket does this belong to? https://codereview.appspot.com/342790043/diff/1/common/putil.cpp File ...

6 years ago (2018-04-03 19:51:48 UTC) #2

sffc

I don't think there's a ticket in particular; I think I committed this change under ...

6 years ago (2018-04-05 21:54:17 UTC) #3

sffc

6 years ago (2018-04-05 21:55:52 UTC) #4

The original commit was r41136, and I removed the stray #include in r41199.