Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(384)

Issue 34270044: Extract the message from EnvError on deploy err.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by bac
Modified:
6 years, 4 months ago
Reviewers:
mp+196966, gary.poster
Visibility:
Public.

Description

Extract the message from EnvError on deploy err. https://code.launchpad.net/~bac/charms/precise/juju-gui/enverror/+merge/196966 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Extract the message from EnvError on deploy err. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/bundles/utils.py View 2 chunks +5 lines, -2 lines 0 comments Download
M server/guiserver/tests/bundles/test_base.py View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/tests/bundles/test_utils.py View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 4
bac
Please take a look.
6 years, 4 months ago (2013-11-27 19:37:17 UTC) #1
bac
To QA: The charm needs to have the juju-gui trunk. I tried just setting juju-gui-source ...
6 years, 4 months ago (2013-11-27 21:27:36 UTC) #2
gary.poster
LGTM and QA good. Very nice that the fix could be so simple. (Separately, I ...
6 years, 4 months ago (2013-11-27 21:49:24 UTC) #3
bac
6 years, 4 months ago (2013-11-27 21:54:21 UTC) #4
*** Submitted:

Extract the message from EnvError on deploy err.

R=gary.poster
CC=
https://codereview.appspot.com/34270044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b