Issue 3426043: Clean up SPI Makefile-bits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3426043: Clean up SPI Makefile-bits (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by larrygritz

Modified:
13 years, 4 months ago

Reviewers:
ckulla

Base URL:
http://svn.openimageio.org/oiio/trunk/

Visibility:
Public.

Description

Indent for clarity. Simplify 'if' nesting. Use '?=' where applicable.

Patch Set 2 : Like this? #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -62 lines)			Patch
		site/spi/Makefile-bits	View	1	2 chunks	+56 lines, -62 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ckulla

http://codereview.appspot.com/3426043/diff/1/site/spi/Makefile-bits File site/spi/Makefile-bits (right): http://codereview.appspot.com/3426043/diff/1/site/spi/Makefile-bits#newcode12 site/spi/Makefile-bits:12: SOVERSION:=${OPENIMAGEIO_SPCOMP2_VERSION} This needs to be moved down ... http://codereview.appspot.com/3426043/diff/1/site/spi/Makefile-bits#newcode100 ...

13 years, 4 months ago (2010-12-08 22:35:08 UTC) #2

ckulla

13 years, 4 months ago (2010-12-08 22:44:57 UTC) #4

On 2010/12/08 22:43:48, larrygritz wrote:
> Like this?

That should do it!

LGTM

Expand All Messages | Collapse All Messages