Run juju init if environments.yaml is missing

Run juju init if environments.yaml is missing

Create environments.yaml and use local provider if environments.yaml is not found.

To test: make check

To QA:
1. mv ~/.juju/environments.yaml ~/.juju/environments.yaml.bak
2. .venv/bin/python juju-quickstart <bundle> # should run juju init and juju switch local
3. ensure deployment goes as planned, ensure ~/.juju/environments.yaml is default from init
4. mv ~/.juju/environments.yaml.bak ~/.juju/environments.yaml

https://code.launchpad.net/~makyo/juju-quickstart/create-environments/+merge/196969

(do not edit description out of merge proposal)

[matthew.scott, 2013-11-27 19:58:14]

Please take a look.

[bac, 2013-11-27 20:28:52]

Code LGTM.  I cannot do QA right now, though.

https://codereview.appspot.com/34260044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/34260044/diff/1/quickstart/app.py#newcode93
quickstart/app.py:93: if retcode:
Are the two different retcode tests on purpose (one for positive number, one for
non-zero)?

[matthew.scott, 2013-11-27 21:31:46]

NB: this is for fixing #1247214 quickly; future work with environments.yaml will
not use juju init.

https://codereview.appspot.com/34260044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/34260044/diff/1/quickstart/app.py#newcode93
quickstart/app.py:93: if retcode:
On 2013/11/27 20:28:52, bac wrote:
> Are the two different retcode tests on purpose (one for positive number, one
for
> non-zero)?

Ah-hah, I'm overloading retcode.  Will look into different variable names.

[bac, 2013-11-27 22:11:57]

QA OK

[frankban, 2013-12-02 17:19:27]

The branch is good Matthew, thanks.
LGTM with the change requested below.

https://codereview.appspot.com/34260044/diff/1/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/34260044/diff/1/quickstart/app.py#newcode89
quickstart/app.py:89: retcode, _, error = utils.call('juju', 'switch')
We don't need to call juju switch here.
utils.get_default_env_name already does it.

https://codereview.appspot.com/34260044/diff/1/quickstart/manage.py
File quickstart/manage.py (right):

https://codereview.appspot.com/34260044/diff/1/quickstart/manage.py#newcode133
quickstart/manage.py:133: options.env_name =
app.ensure_environments(options.env_name)
The env name is already in the namespace: if options.env_name is None that means
we were not able to retrieve the default environment, and I guess we can assume
the environments.yaml is missing.
As you mentioned, this code will be replaced by a more accurate environments
parsing, but for the time being I'd suggest to reuse the existing logic.

[matthew.scott, 2013-12-02 22:39:07]

*** Submitted:

Run juju init if environments.yaml is missing

Create environments.yaml and use local provider if environments.yaml is not
found.

To test: make check

To QA:
1. mv ~/.juju/environments.yaml ~/.juju/environments.yaml.bak
2. .venv/bin/python juju-quickstart <bundle> # should run juju init and juju
switch local
3. ensure deployment goes as planned, ensure ~/.juju/environments.yaml is
default from init
4. mv ~/.juju/environments.yaml.bak ~/.juju/environments.yaml

R=bac, frankban
CC=
https://codereview.appspot.com/34260044